From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dan Nicolaescu Newsgroups: gmane.emacs.devel Subject: Re: mode-line menu for minor modes Date: Thu, 21 Feb 2008 01:17:09 -0800 Message-ID: <200802210917.m1L9H9AT005421@sallyv1.ics.uci.edu> References: <200802190809.m1J89C74001353@sallyv1.ics.uci.edu> <008201c87372$3d5b2ab0$0600a8c0@us.oracle.com> <200802200629.m1K6TIoH027637@sallyv1.ics.uci.edu> <007601c8741e$57f0d120$c2b22382@us.oracle.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1203585627 6123 80.91.229.12 (21 Feb 2008 09:20:27 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 21 Feb 2008 09:20:27 +0000 (UTC) Cc: emacs-devel@gnu.org To: "Drew Adams" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Feb 21 10:20:52 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1JS7bg-0000ne-ON for ged-emacs-devel@m.gmane.org; Thu, 21 Feb 2008 10:20:48 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JS7b4-00062H-HC for ged-emacs-devel@m.gmane.org; Thu, 21 Feb 2008 04:20:06 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JS7aL-0004wC-5l for emacs-devel@gnu.org; Thu, 21 Feb 2008 04:19:21 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JS7aK-0004un-GX for emacs-devel@gnu.org; Thu, 21 Feb 2008 04:19:20 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JS7aK-0004uZ-86 for emacs-devel@gnu.org; Thu, 21 Feb 2008 04:19:20 -0500 Original-Received: from sallyv1.ics.uci.edu ([128.195.1.109]) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_3DES_EDE_CBC_SHA1:24) (Exim 4.60) (envelope-from ) id 1JS7aI-0000ws-JZ for emacs-devel@gnu.org; Thu, 21 Feb 2008 04:19:19 -0500 X-ICS-MailScanner-Watermark: 1204190231.56103@A5lFPZExi3wjreOVDjMgjA Original-Received: from mothra.ics.uci.edu (mothra.ics.uci.edu [128.195.6.93]) by sallyv1.ics.uci.edu (8.13.7+Sun/8.13.7) with ESMTP id m1L9H9AT005421; Thu, 21 Feb 2008 01:17:09 -0800 (PST) In-Reply-To: <007601c8741e$57f0d120$c2b22382@us.oracle.com> (Drew Adams's message of "Wed, 20 Feb 2008 16:11:44 -0800") Original-Lines: 52 X-ICS-MailScanner: Found to be clean X-ICS-MailScanner-SpamCheck: not spam, SpamAssassin (score=-1.44, required 5, autolearn=disabled, ALL_TRUSTED -1.44) X-ICS-MailScanner-From: dann@mothra.ics.uci.edu X-detected-kernel: by monty-python.gnu.org: Solaris 10 (beta) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:89795 Archived-At: "Drew Adams" writes: > > > > The new feature to pop a menu when clicking on the mode-line > > > > :lighter for > > > > minor modes is great. > > > > > > > > But for minor modes that don't provide a menu, just an error > > > > message is > > > > displayed: "No menu for minor mode `BLAH'". This is > > > > not very helpful > > > > for the user, it would be nicer to pop up a menu that > > > > has (at least) 2 > > > > entries: - one to turn off the minor mode > > > > - one to show the help for that minor mode. > > > > > > > > Yes, these are available elsewhere, but it's better to > > > > provide something > > > > useful and consistent for mouse-1 instead of just > > > > complaining that a menu is not available. > > > > > > Good idea. > > > > Given that you wrote the rest of the minor mode menu popup > > code, do you > > want to implement this too? > > OK - see below. Thank you! > I wanted to make a patch, but apparently I don't know how to > find the latest CVS version. When I look at what I think would be the latest > version, namely the first download link at > http://cvs.savannah.gnu.org/viewvc/emacs/emacs/lisp/bindings.el?view=log, it > shows a version of bindings.el that does not have the changes I submitted. > But you are apparently seeing some version that does include that patch. > If you tell me how to find the right version to patch, I'll send a patch. If > not, here is the updated function definition - just substitute this for the > definition I sent in my September patch. cvs -d :pserver:anonymous@cvs.savannah.gnu.org:/cvsroot/emacs co emacs/lisp/mouse.el > Note: I added (sleep-for 1) because the turned-off message is otherwise > erased immediately, at least in my environment. If it works for you without > the sleep-for, then go ahead and remove it. Works fine without it. I also took out the read-event call. I checked in your changes. Thanks!