lisp/mail/rmail.el rmail-highlight definition

lisp/mail/rmail.el rmail-highlight definition

[pod]

I don't think the definition for the rmail-highlight face in emacs 22.1 is
correct.

The face properties shown by M-x describe-face RET rmail-highlight are all
unspecified and indeed M-x list-faces-display shows the rmail-highlight
faces as completely plain whereas the highlight face has a darkolivegreen
(according to M-x describe-face RET highlight) background.

The rmail-highlight face definition appears to be the same in CVS

<http://cvs.savannah.gnu.org/viewvc/emacs/emacs/lisp/mail/rmail.el?revision=1.445&view=markup>

as it is in the lisp/mail/rmail.el from the distributed emacs 22.1
tarball, namely:

    (defface rmail-highlight
      '((t :default highlight))
      "Face to use for highlighting the most important header fields."
      :group 'rmail-headers
      :version "22.1")

I think the intent is to derive a face from the highlight face, however
the value used above appears to be incorrect on two counts given the
description from M-x describe-function defface; there is no :default ATTR
and ATTS should be (ATTR VALUE ATTR VALUE ...).

I believe the correct value to assign is ((t (:inherit hightlight))).
Indeed if I assign this using

(custom-set-faces '(rmail-highlight ((t (:inherit highlight)))))

I observe the content of From: and Subject: fields in my rmail buffers in
a face indistinguishable from the highlight face (i.e. with a
darkolivegreen background) whereas without this setting they appear in
what looks like the default face.

Thank you for your time.

Re: lisp/mail/rmail.el rmail-highlight definition

[martin rudalics]

> I don't think the definition for the rmail-highlight face in emacs 22.1 is
> correct.
> 
> The face properties shown by M-x describe-face RET rmail-highlight are all
> unspecified and indeed M-x list-faces-display shows the rmail-highlight
> faces as completely plain whereas the highlight face has a darkolivegreen
> (according to M-x describe-face RET highlight) background.
> 
> The rmail-highlight face definition appears to be the same in CVS
> 
> <http://cvs.savannah.gnu.org/viewvc/emacs/emacs/lisp/mail/rmail.el?revision=1.445&view=markup>
> 
> as it is in the lisp/mail/rmail.el from the distributed emacs 22.1
> tarball, namely:
> 
>     (defface rmail-highlight
>       '((t :default highlight))
>       "Face to use for highlighting the most important header fields."
>       :group 'rmail-headers
>       :version "22.1")
> 
> I think the intent is to derive a face from the highlight face, however
> the value used above appears to be incorrect on two counts given the
> description from M-x describe-function defface; there is no :default ATTR
> and ATTS should be (ATTR VALUE ATTR VALUE ...).
> 
> I believe the correct value to assign is ((t (:inherit hightlight))).
> Indeed if I assign this using
> 
> (custom-set-faces '(rmail-highlight ((t (:inherit highlight)))))
> 
> I observe the content of From: and Subject: fields in my rmail buffers in
> a face indistinguishable from the highlight face (i.e. with a
> darkolivegreen background) whereas without this setting they appear in
> what looks like the default face.
> 
> Thank you for your time.

Thank you very much for your precise report.  I've installed the fix you
suggested in the Emacs 22.2 branch.  It should soon get merged into the
trunk.