VC Dired Mode doesn't support recursive directory?

VC Dired Mode doesn't support recursive directory?

[William Xu]

1. M-x vc-directory gives me a list of changed files in current
   directory and one sub directory.

2. I marked all files, then `v v', it prompts this in the minibuffer: 

,----
| All members of a fileset must be under the same version-control system.
`----

The directory is a svn repo. I can do the above successfully on the
shell command line.

,----[ M-x emacs-version ]
| GNU Emacs 23.0.50.4 (i386-apple-darwin9.1.0, Carbon Version 1.6.0) of 2008-01-24 on zen
`----

-- 
William

http://williamxu.net9.org

Re: VC Dired Mode doesn't support recursive directory?

[Dan Nicolaescu]

William Xu <william.xwl@gmail.com> writes:

  > 1. M-x vc-directory gives me a list of changed files in current
  >    directory and one sub directory.
  > 
  > 2. I marked all files, then `v v', it prompts this in the minibuffer: 
  >
  > ,----
  > | All members of a fileset must be under the same version-control system.
  > `----

Were some of the files that you selected unregistered? If yes, then the
error you get is expected (although the wording could be improved to
make it more clear).

Re: VC Dired Mode doesn't support recursive directory?

[Stefan Monnier]

>> 1. M-x vc-directory gives me a list of changed files in current
>> directory and one sub directory.
>> 
>> 2. I marked all files, then `v v', it prompts this in the minibuffer: 
>> 
>> ,----
>> | All members of a fileset must be under the same version-control system.
>> `----

> Were some of the files that you selected unregistered? If yes, then the
> error you get is expected (although the wording could be improved to
> make it more clear).

BTW, I think there's a fundamental error in VC's handling of backends,
right now:  The backend should be a buffer-local property, not
a file-local property.


        Stefan

Re: VC Dired Mode doesn't support recursive directory?

[Dan Nicolaescu]

Stefan Monnier <monnier@iro.umontreal.ca> writes:

  > >> 1. M-x vc-directory gives me a list of changed files in current
  > >> directory and one sub directory.
  > >> 
  > >> 2. I marked all files, then `v v', it prompts this in the minibuffer: 
  > >> 
  > >> ,----
  > >> | All members of a fileset must be under the same version-control system.
  > >> `----
  > 
  > > Were some of the files that you selected unregistered? If yes, then the
  > > error you get is expected (although the wording could be improved to
  > > make it more clear).
  > 
  > BTW, I think there's a fundamental error in VC's handling of backends,
  > right now:  The backend should be a buffer-local property, not
  > a file-local property.

So what happens with files that are not in any buffer (like probably a
lot of files that would appear in vc-dired)?

Re: VC Dired Mode doesn't support recursive directory?

[Stefan Monnier]

>> >> 1. M-x vc-directory gives me a list of changed files in current
>> >> directory and one sub directory.
>> >> 
>> >> 2. I marked all files, then `v v', it prompts this in the minibuffer: 
>> >> 
>> >> ,----
>> >> | All members of a fileset must be under the same version-control system.
>> >> `----
>> 
>> > Were some of the files that you selected unregistered? If yes, then the
>> > error you get is expected (although the wording could be improved to
>> > make it more clear).
>> 
>> BTW, I think there's a fundamental error in VC's handling of backends,
>> right now:  The backend should be a buffer-local property, not
>> a file-local property.

> So what happens with files that are not in any buffer (like probably a
> lot of files that would appear in vc-dired)?

Huh?  If they're in vc-dired, they're in a buffer.
That's the whole point: it ensures trivially that all the files selected
in a vc-dired are treated by the same backend.


        Stefan

Re: VC Dired Mode doesn't support recursive directory?

[Dan Nicolaescu]

Stefan Monnier <monnier@iro.umontreal.ca> writes:

  > >> >> 1. M-x vc-directory gives me a list of changed files in current
  > >> >> directory and one sub directory.
  > >> >> 
  > >> >> 2. I marked all files, then `v v', it prompts this in the minibuffer: 
  > >> >> 
  > >> >> ,----
  > >> >> | All members of a fileset must be under the same version-control system.
  > >> >> `----
  > >> 
  > >> > Were some of the files that you selected unregistered? If yes, then the
  > >> > error you get is expected (although the wording could be improved to
  > >> > make it more clear).
  > >> 
  > >> BTW, I think there's a fundamental error in VC's handling of backends,
  > >> right now:  The backend should be a buffer-local property, not
  > >> a file-local property.
  > 
  > > So what happens with files that are not in any buffer (like probably a
  > > lot of files that would appear in vc-dired)?
  > 
  > Huh?  If they're in vc-dired, they're in a buffer.

There seems to be a misunderstanding here. Why would the files be in a
buffer? One can edit something, quit emacs and then 2 weeks later run
vc-dired.  It's possible that none of the files that vc-dired shows to
be in a buffer.

Re: VC Dired Mode doesn't support recursive directory?

[Stefan Monnier]

>> >> >> 1. M-x vc-directory gives me a list of changed files in current
>> >> >> directory and one sub directory.
>> >> >> 
>> >> >> 2. I marked all files, then `v v', it prompts this in the minibuffer: 
>> >> >> 
>> >> >> ,----
>> >> >> | All members of a fileset must be under the same version-control system.
>> >> >> `----
>> >> 
>> >> > Were some of the files that you selected unregistered? If yes, then the
>> >> > error you get is expected (although the wording could be improved to
>> >> > make it more clear).
>> >> 
>> >> BTW, I think there's a fundamental error in VC's handling of backends,
>> >> right now:  The backend should be a buffer-local property, not
>> >> a file-local property.
>> 
>> > So what happens with files that are not in any buffer (like probably a
>> > lot of files that would appear in vc-dired)?
>> 
>> Huh?  If they're in vc-dired, they're in a buffer.

> There seems to be a misunderstanding here. Why would the files be in a
> buffer? One can edit something, quit emacs and then 2 weeks later run
> vc-dired.  It's possible that none of the files that vc-dired shows to
> be in a buffer.

But any VC operation is run from a buffer.  Either a file buffer or a VC
buffer.  The backend to use should depend on the buffer, not on the (set
of) file(s).


        Stefan

Re: VC Dired Mode doesn't support recursive directory?

[Dan Nicolaescu]

Stefan Monnier <monnier@iro.umontreal.ca> writes:

  > >> >> >> 1. M-x vc-directory gives me a list of changed files in current
  > >> >> >> directory and one sub directory.
  > >> >> >> 
  > >> >> >> 2. I marked all files, then `v v', it prompts this in the minibuffer: 
  > >> >> >> 
  > >> >> >> ,----
  > >> >> >> | All members of a fileset must be under the same version-control system.
  > >> >> >> `----
  > >> >> 
  > >> >> > Were some of the files that you selected unregistered? If yes, then the
  > >> >> > error you get is expected (although the wording could be improved to
  > >> >> > make it more clear).
  > >> >> 
  > >> >> BTW, I think there's a fundamental error in VC's handling of backends,
  > >> >> right now:  The backend should be a buffer-local property, not
  > >> >> a file-local property.
  > >> 
  > >> > So what happens with files that are not in any buffer (like probably a
  > >> > lot of files that would appear in vc-dired)?
  > >> 
  > >> Huh?  If they're in vc-dired, they're in a buffer.
  > 
  > > There seems to be a misunderstanding here. Why would the files be in a
  > > buffer? One can edit something, quit emacs and then 2 weeks later run
  > > vc-dired.  It's possible that none of the files that vc-dired shows to
  > > be in a buffer.
  > 
  > But any VC operation is run from a buffer.  Either a file buffer or a VC
  > buffer.  The backend to use should depend on the buffer, not on the (set
  > of) file(s).

Well, for vc-dired different files can belong to different backends. If
you are saying that its not a good idea, then we are in complete
agreement.

Re: VC Dired Mode doesn't support recursive directory?

[Stefan Monnier]

>> But any VC operation is run from a buffer.  Either a file buffer or a VC
>> buffer.  The backend to use should depend on the buffer, not on the (set
>> of) file(s).

> Well, for vc-dired different files can belong to different backends. If
> you are saying that its not a good idea, then we are in complete
> agreement.

No, I'm saying that in order for VC-dired to make sense when files can
belong to several backends, the "current backend" should be per-buffer
rather than per-file.

So you can have a VC-dired buffer in CVS mode on /foo/bar while having
file /foo/bar/baz in another buffer and switching between CVS and RCS
backends in that buffer.


        Stefan

Re: VC Dired Mode doesn't support recursive directory?

[William Xu]

Dan Nicolaescu <dann@ics.uci.edu> writes:

> Were some of the files that you selected unregistered? If yes, then the
> error you get is expected (although the wording could be improved to
> make it more clear).

No, they are all already registered. 

I found the cause, it is because i have sort directory first in dired
buffer. Namely, I have the following in my .emacs: 

,----
| ;; Sort directories first
| (defun sof/dired-sort ()
|   "Dired sort hook to list directories first."
|   (save-excursion
|     (let (buffer-read-only)
|       (forward-line 2) ;; beyond dir. header
|       (sort-regexp-fields t "^.*$" "[ ]*." (point)
|                           (point-max))))
|   (set-buffer-modified-p nil))
| 
| (add-hook 'dired-after-readin-hook 'sof/dired-sort)
`----

Can VC Dired Mode handle this case?

-- 
William

http://williamxu.net9.org

Re: VC Dired Mode doesn't support recursive directory?

[Dan Nicolaescu]

William Xu <william.xwl@gmail.com> writes:

  > Dan Nicolaescu <dann@ics.uci.edu> writes:
  > 
  > > Were some of the files that you selected unregistered? If yes, then the
  > > error you get is expected (although the wording could be improved to
  > > make it more clear).
  > 
  > No, they are all already registered. 
  > 
  > I found the cause, it is because i have sort directory first in dired
  > buffer. Namely, I have the following in my .emacs: 
  > 
  > ,----
  > | ;; Sort directories first
  > | (defun sof/dired-sort ()
  > |   "Dired sort hook to list directories first."
  > |   (save-excursion
  > |     (let (buffer-read-only)
  > |       (forward-line 2) ;; beyond dir. header
  > |       (sort-regexp-fields t "^.*$" "[ ]*." (point)
  > |                           (point-max))))
  > |   (set-buffer-modified-p nil))
  > | 
  > | (add-hook 'dired-after-readin-hook 'sof/dired-sort)
  >
  > Can VC Dired Mode handle this case?

This seems to directly modify the dired buffer, so probably something
goes wrong there.

If you can reproduce the problem starting from emacs -Q without the code
above, the please report back.

Also vc-dired is very likely to get replaced soon...

Re: VC Dired Mode doesn't support recursive directory?

[William Xu]

Dan Nicolaescu <dann@ics.uci.edu> writes:

> This seems to directly modify the dired buffer, so probably something
> goes wrong there.
>
> If you can reproduce the problem starting from emacs -Q without the code
> above, the please report back.

No, it doesn't happen with -Q or simply by removing that hook.

> Also vc-dired is very likely to get replaced soon...

Okay, then I will fall back on the command line at the moment..

-- 
William

http://williamxu.net9.org