From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dan Nicolaescu Newsgroups: gmane.emacs.devel Subject: Re: State of VC? Date: Wed, 23 Jan 2008 23:07:19 -0800 Message-ID: <200801240707.m0O77KcX018757@sallyv1.ics.uci.edu> References: <20080122164306.3B33C83045C@snark.thyrsus.com> <200801222207.m0MM7rlR014153@sallyv1.ics.uci.edu> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1201158591 1425 80.91.229.12 (24 Jan 2008 07:09:51 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 24 Jan 2008 07:09:51 +0000 (UTC) Cc: Tom Tromey , "Eric S. Raymond" , emacs-devel@gnu.org To: Glenn Morris Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Jan 24 08:10:10 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1JHwDx-0008Hq-TP for ged-emacs-devel@m.gmane.org; Thu, 24 Jan 2008 08:10:10 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JHwDX-0002FR-LE for ged-emacs-devel@m.gmane.org; Thu, 24 Jan 2008 02:09:43 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JHwDE-0002CG-AY for emacs-devel@gnu.org; Thu, 24 Jan 2008 02:09:24 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JHwDD-0002BS-8m for emacs-devel@gnu.org; Thu, 24 Jan 2008 02:09:24 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JHwDD-0002BI-0V for emacs-devel@gnu.org; Thu, 24 Jan 2008 02:09:23 -0500 Original-Received: from sallyv1.ics.uci.edu ([128.195.1.109]) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_3DES_EDE_CBC_SHA1:24) (Exim 4.60) (envelope-from ) id 1JHwD8-00063p-SJ; Thu, 24 Jan 2008 02:09:19 -0500 X-ICS-MailScanner-Watermark: 1201763243.48218@g+6ak0XUv0IKt2j2mQrk3w Original-Received: from mothra.ics.uci.edu (mothra.ics.uci.edu [128.195.6.93]) by sallyv1.ics.uci.edu (8.13.7+Sun/8.13.7) with ESMTP id m0O77KcX018757; Wed, 23 Jan 2008 23:07:20 -0800 (PST) In-Reply-To: (Glenn Morris's message of "Tue, 22 Jan 2008 17:26:26 -0500") Original-Lines: 79 X-ICS-MailScanner: Found to be clean X-ICS-MailScanner-SpamCheck: not spam, SpamAssassin (score=-1.44, required 5, autolearn=disabled, ALL_TRUSTED -1.44) X-ICS-MailScanner-From: dann@mothra.ics.uci.edu X-detected-kernel: by monty-python.gnu.org: Solaris 10 (beta) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:87423 Archived-At: Glenn Morris writes: > Dan Nicolaescu wrote: > > > Pointers? > > I only remember one bug: > > http://permalink.gmane.org/gmane.emacs.devel/87064 > > Links to VC-related issues that are unaddressed AFAIK. Some of them > may well be dealt with - you will know better than I. > > > strange window behavior from vc-diff > http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01276.html The problem here is indeed in vc-diff-sentinel. It calls (shrink-window-if-larger-than-buffer) which does this: (when (null window) (setq window (selected-window))) So it will look at (selected-window), so it will shrink the wrong window... Not sure what the best solution is here. > vc-dired refresh > http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01268.html This is for vc-dired. Needs to be looked checked if it still happens when vc-dired is replaced with vc-status. > Patch: vc-dired-hook -vs- vc-call > http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg00549.html > > Further VC tuning is blocked > http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg00410.html Already replied about these in another message. > strange byte compiler behavior > http://lists.gnu.org/archive/html/emacs-devel/2007-12/msg01356.html > > vc.el complaint about reference to free variable `file' > http://lists.gnu.org/archive/html/emacs-devel/2007-12/msg00872.html Still need fixing. > wrong behaviour of vc-workfile-unchanged-p > http://lists.gnu.org/archive/html/emacs-devel/2007-12/msg00867.html The analysis in the bug report seems correct. Opinions on this patch? (this code has been around for a long time...) --- vc-hooks.el.~1.220.~2008-01-13 10:45:01.000000000 -0800 +++ vc-hooks.el2008-01-23 23:01:02.000000000 -0800 @@ -558,10 +558,11 @@ (if (and checkout-time ;; Tramp and Ange-FTP return this when they don't know the time. (not (equal lastmod '(0 0)))) - (equal checkout-time lastmod) - (let ((unchanged (vc-call workfile-unchanged-p file))) - (vc-file-setprop file 'vc-checkout-time (if unchanged lastmod 0)) - unchanged)))) + (if (equal checkout-time lastmod) + t + (let ((unchanged (vc-call workfile-unchanged-p file))) + (vc-file-setprop file 'vc-checkout-time (if unchanged lastmod 0)) + unchanged))))) (defun vc-default-workfile-unchanged-p (backend file) "Check if FILE is unchanged by diffing against the master version. > [chet.wood@sun.com: vc-sccs-workfile-version returns wrong version number] > http://lists.gnu.org/archive/html/emacs-devel/2007-11/msg01572.html No idea.