From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dan Nicolaescu Newsgroups: gmane.emacs.devel Subject: Re: patch: add-log.el: changelog find file under poin Date: Tue, 22 Jan 2008 15:13:35 -0800 Message-ID: <200801222313.m0MNDeb3013484@sallyv1.ics.uci.edu> References: <1194211092.13041.13.camel@peder.flower> <200801220821.m0M8LJ57017486@sallyv1.ics.uci.edu> <87bq7e88sf.fsf@jurta.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1201043733 17542 80.91.229.12 (22 Jan 2008 23:15:33 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 22 Jan 2008 23:15:33 +0000 (UTC) Cc: emacs-devel@gnu.org, rms@gnu.org, Jan Nieuwenhuizen To: Juri Linkov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Jan 23 00:15:50 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1JHSLM-0006WS-JW for ged-emacs-devel@m.gmane.org; Wed, 23 Jan 2008 00:15:48 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JHSKw-0006nw-Ky for ged-emacs-devel@m.gmane.org; Tue, 22 Jan 2008 18:15:22 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JHSKr-0006lk-Uq for emacs-devel@gnu.org; Tue, 22 Jan 2008 18:15:17 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JHSKq-0006lX-GW for emacs-devel@gnu.org; Tue, 22 Jan 2008 18:15:17 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JHSKq-0006lU-Dz for emacs-devel@gnu.org; Tue, 22 Jan 2008 18:15:16 -0500 Original-Received: from sallyv1.ics.uci.edu ([128.195.1.109]) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_3DES_EDE_CBC_SHA1:24) (Exim 4.60) (envelope-from ) id 1JHSKm-0001N4-H0; Tue, 22 Jan 2008 18:15:12 -0500 X-ICS-MailScanner-Watermark: 1201648425.72908@o28yXevW2+ItlBHPl0CJ2w Original-Received: from mothra.ics.uci.edu (mothra.ics.uci.edu [128.195.6.93]) by sallyv1.ics.uci.edu (8.13.7+Sun/8.13.7) with ESMTP id m0MNDeb3013484; Tue, 22 Jan 2008 15:13:45 -0800 (PST) In-Reply-To: <87bq7e88sf.fsf@jurta.org> (Juri Linkov's message of "Tue, 22 Jan 2008 11:56:32 +0200") Original-Lines: 19 X-ICS-MailScanner: Found to be clean X-ICS-MailScanner-SpamCheck: not spam, SpamAssassin (score=-1.44, required 5, autolearn=disabled, ALL_TRUSTED -1.44) X-ICS-MailScanner-From: dann@mothra.ics.uci.edu X-detected-kernel: by monty-python.gnu.org: Solaris 10 (beta) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:87332 Archived-At: Juri Linkov writes: > > An improvement that would make this even more useful would be that after > > finding the file, it should do a search for the item the point is > > on. That won't always find the correct function/variable/etc. the log > > entry refers to, but it will help the user a lot when it does. > > Using the logic from `add-log-current-defun' might be unreliable, but > maybe it is better to rely on imenu to find the item in the source file. > What other package could do this? (find-func is only for Emacs Lisp, > and etags requires the TAGS file.) The problem with those is that the user might not have imenu turned on, so it would take a while to index the file, and might not have TAGS. Another problem is if the entry is about something that has been deleted or renamed. IMHO it would be better to first go the easy way and to a simple string search, and maybe later try to implement something more fancy.