From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dan Nicolaescu Newsgroups: gmane.emacs.devel Subject: Re: Introducing 'unrecognized and 'ignored Date: Mon, 21 Jan 2008 17:35:47 -0800 Message-ID: <200801220135.m0M1ZwEE010855@sallyv1.ics.uci.edu> References: <17EA38DF-BCC1-4565-8510-5DD10DD667E3@mac.com> <20071229114551.GD9794@thyrsus.com> <20080102021907.GA15494@thyrsus.com> <200801020445.m024jWU2008538@oogie-boogie.ics.uci.edu> <200801031805.m03I5SBf022748@oogie-boogie.ics.uci.edu> <200801050901.m0591mQj011970@oogie-boogie.ics.uci.edu> <20080105143415.GG30869@thyrsus.com> <200801061037.m06AbIRD004966@oogie-boogie.ics.uci.edu> <200801182346.m0INkiEg022130@sallyv1.ics.uci.edu> <200801191705.m0JH5WOU026943@sallyv1.ics.uci.edu> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1200965788 19402 80.91.229.12 (22 Jan 2008 01:36:28 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 22 Jan 2008 01:36:28 +0000 (UTC) Cc: esr@thyrsus.com, harsanyi@mac.com, Stefan Monnier , rms@gnu.org, emacs-devel@gnu.org To: Tom Tromey Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Jan 22 02:36:45 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1JH84B-0000EC-Td for ged-emacs-devel@m.gmane.org; Tue, 22 Jan 2008 02:36:44 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JH83l-0000jA-To for ged-emacs-devel@m.gmane.org; Mon, 21 Jan 2008 20:36:17 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JH83h-0000j4-UD for emacs-devel@gnu.org; Mon, 21 Jan 2008 20:36:13 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JH83g-0000in-7k for emacs-devel@gnu.org; Mon, 21 Jan 2008 20:36:12 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JH83g-0000ik-2d for emacs-devel@gnu.org; Mon, 21 Jan 2008 20:36:12 -0500 Original-Received: from sallyv1.ics.uci.edu ([128.195.1.109]) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_3DES_EDE_CBC_SHA1:24) (Exim 4.60) (envelope-from ) id 1JH83c-0007V5-1Z; Mon, 21 Jan 2008 20:36:08 -0500 X-ICS-MailScanner-Watermark: 1201570559.87281@fIcmw5Mi80cZG6DmbKEq+Q Original-Received: from mothra.ics.uci.edu (mothra.ics.uci.edu [128.195.6.93]) by sallyv1.ics.uci.edu (8.13.7+Sun/8.13.7) with ESMTP id m0M1ZwEE010855; Mon, 21 Jan 2008 17:35:58 -0800 (PST) In-Reply-To: (Tom Tromey's message of "Sun, 20 Jan 2008 12:45:37 -0700") Original-Lines: 33 X-ICS-MailScanner: Found to be clean X-ICS-MailScanner-SpamCheck: not spam, SpamAssassin (score=-1.44, required 5, autolearn=disabled, ALL_TRUSTED -1.44) X-ICS-MailScanner-From: dann@mothra.ics.uci.edu X-detected-kernel: by monty-python.gnu.org: Solaris 10 (beta) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:87271 Archived-At: Tom Tromey writes: > >> I hook into vc-do-command... I'm not sure if that is really a good idea. > >> I guess that's why we have patch review :-) > > Stefan> I general it doesn't sound like a bad idea, but I'll reserve > Stefan> my judgment until I see the code. > > Here's the patch I've got. > > Note there is a bug fix to vc-update-vc-status-buffer in here... this > should go in even if the rest of the patch does not. You can see this > bug by running vc-status in a directory with no modifications and no > unrecognized files. > > Stefan> PCL-CVS used to clear the ewoc, so I obviously believe it's > Stefan> worth the effort to not clear it, so as to preserve mark and > Stefan> such. > > Yeah. In general I think vc-status should follow PCL-CVS unless there > is a really good reason to be different. IMHO displaying the command that is running is overkill. I don't think VC users would care about it, they just want to see that something is happening. Generic messages like Updating/Committing/Reading Status should be enough. (PCL-CVS does print the command, but I personally never payed attention to what it prints there...). Coupled with something that displays the running status in the mode-line (like it is now done for diff/log/annotate). About the footer message: I am afraid that it would get the same opposition as the text at the end of vc-diff recently got.