Re: [nico@ngolde.de: some code issues]

From: Nico Golde <nico@ngolde.de>
To: Chong Yidong <cyd@stupidchicken.com>
Cc: rms@gnu.org, emacs-devel@gnu.org
Subject: Re: [nico@ngolde.de: some code issues]
Date: Thu, 10 Jan 2008 16:35:46 +0100	[thread overview]
Message-ID: <20080110153546.GB31176@ngolde.de> (raw)
In-Reply-To: <87tzllzonn.fsf@stupidchicken.com>

[-- Attachment #1.1: Type: text/plain, Size: 870 bytes --]

Hi Chong,
* Chong Yidong <cyd@stupidchicken.com> [2008-01-10 16:29]:
> > I had a quick look at the pop.c code today and found some
> > issues.
> >
> > In pop_stat:
> >
> > If I don't miss anything the atoi call in 380 is not save as it is not
> > save because it is not ensure that &fromserver[4] is not NULL. A crafted
> > pop3 server could thus crash emacs. This is of course not a real issue but
> > wouldn't be nice. Same for the pop_last function.
> >
> > In pop_list:
> >
> > in 441 and 442 there should be some check for how_many to prevent an integer
> > overflow here.
> 
> Fixed.  Thanks for pointing these out.

What do you think about requesting a CVE id for this?

Kind regards
Nico
-- 
Nico Golde - http://www.ngolde.de - nion@jabber.ccc.de - GPG: 0x73647CFF
For security reasons, all text in this mail is double-rot13 encrypted.

[-- Attachment #1.2: Type: application/pgp-signature, Size: 189 bytes --]

[-- Attachment #2: Type: text/plain, Size: 142 bytes --]

_______________________________________________
Emacs-devel mailing list
Emacs-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-devel