From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dan Nicolaescu Newsgroups: gmane.emacs.devel Subject: your changes to ediff*.el and viper*.el Date: Wed, 09 Jan 2008 00:17:08 -0800 Message-ID: <200801090817.m098HBqI006233@oogie-boogie.ics.uci.edu> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1199866768 28773 80.91.229.12 (9 Jan 2008 08:19:28 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 9 Jan 2008 08:19:28 +0000 (UTC) Cc: emacs-devel@gnu.org To: Michael Kifer Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Jan 09 09:19:50 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1JCWA9-0003u9-O1 for ged-emacs-devel@m.gmane.org; Wed, 09 Jan 2008 09:19:50 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JCW9m-0000JY-B8 for ged-emacs-devel@m.gmane.org; Wed, 09 Jan 2008 03:19:26 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JCW9i-0000HW-B7 for emacs-devel@gnu.org; Wed, 09 Jan 2008 03:19:22 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JCW9h-0000G2-Gd for emacs-devel@gnu.org; Wed, 09 Jan 2008 03:19:21 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JCW9g-0000Fn-VF for emacs-devel@gnu.org; Wed, 09 Jan 2008 03:19:21 -0500 Original-Received: from mx20.gnu.org ([199.232.41.8]) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1JCW9g-00075A-Jq for emacs-devel@gnu.org; Wed, 09 Jan 2008 03:19:20 -0500 Original-Received: from oogie-boogie.ics.uci.edu ([128.195.1.41]) by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1JCW9f-0002Fz-EO for emacs-devel@gnu.org; Wed, 09 Jan 2008 03:19:19 -0500 Original-Received: from mothra.ics.uci.edu (mothra.ics.uci.edu [128.195.6.93]) by oogie-boogie.ics.uci.edu (8.13.6/8.13.6) with ESMTP id m098HBqI006233; Wed, 9 Jan 2008 00:17:11 -0800 (PST) Original-Lines: 27 X-ICS-MailScanner: Found to be clean X-ICS-MailScanner-SpamCheck: not spam, SpamAssassin (score=-1.44, required 5, autolearn=disabled, ALL_TRUSTED -1.44) X-ICS-MailScanner-From: dann@mothra.ics.uci.edu X-detected-kernel: by mx20.gnu.org: Solaris 9 X-detected-kernel: by monty-python.gnu.org: Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:86625 Archived-At: Hi, Can you please revert these changes: * viper*.el: commented out declare-function -- not defined in XEmacs. * ediff*.el: commented out declare-function. "make bootstrap" stops with an error and emacs does not compile with those things in. Besides, declare-function is not defined in XEmacs. Your build fails because it is stale, you need to do a "make maintainer-clean", it will succeed after that. As for compatibility with XEmacs, there already is a standard solution used by several files in the tree that need XEmacs compatibility: (eval-and-compile (unless (fboundp 'declare-function) (defmacro declare-function (&rest r)))) Thanks --dan