saveplace does not work with emacsclient

saveplace does not work with emacsclient

[P G L Porta Mana]

Please write in English if possible, because the Emacs maintainers
usually do not have translators to read other languages for them.

Your bug report will be posted to the emacs-pretest-bug@gnu.org mailing list.

Please describe exactly what actions triggered the bug
and the precise symptoms of the bug:

Although saveplace-mode is activated by default, in files opened through
emacsclientw the point appears at the beginning of buffer.

This was tested with the following simple .emacs file:

 (server-start)
 (setq-default save-place t)
 (require 'saveplace)


If Emacs crashed, and you have the Emacs process in the gdb debugger,
please include the output from the following gdb commands:
    `bt full' and `xbacktrace'.
If you would like to further debug the crash, please read the file
c:/Program Files/Emacs/etc/DEBUG for instructions.

In GNU Emacs 22.1.50.1 (i386-mingw-nt5.1.2600)
 of 2007-07-07 on NEUTRINO
Windowing system distributor `Microsoft Corp.', version 5.1.2600
configured using `configure --with-gcc (3.4) --cflags -Ic:/Programme/GnuWin32/include'

Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: ENG
  locale-coding-system: cp1252
  default-enable-multibyte-characters: t

Major mode: Fundamental

Minor modes in effect:
  encoded-kbd-mode: t
  tooltip-mode: t
  tool-bar-mode: t
  mouse-wheel-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  unify-8859-on-encoding-mode: t
  utf-translate-cjk-mode: t
  auto-compression-mode: t
  line-number-mode: t

Recent input:
n <help-echo> <down-mouse-1> <mouse-1> <drag-n-drop> 
<next> <next> <next> <next> <next> <next> <next> <next> 
<next> C-x k <return> <drag-n-drop> C-x k <return> 
<help-echo> <help-echo> <help-echo> <help-echo> <help-echo> 
<help-echo> <help-echo> <menu-bar> <help-menu> <re
port-emacs-bug>

Recent messages:
Loading places from c:/Documents and Settings/All Users/Desktop/work/.emacs-places...done
For information about the GNU Project and its goals, type C-h C-p.
Loading bibtex...
Loading easymenu...done
Loading regexp-opt...done
Loading bibtex...done
Please type y, n, or !: 
For information about the GNU Project and its goals, type C-h C-p.
Loading url-util...done
Loading emacsbug...done

Re: saveplace does not work with emacsclient

[Juanma Barranquero]

On Jan 7, 2008 5:41 PM, Karl Fogel <kfogel@red-bean.com> wrote:

> Is "emacsclientw" a typo for "emacsclient", or is there some wrapper
> script going on here that I don't know about?

On Windows, emacsclient.c is built as emacsclient.exe (a console app)
and emacsclientw.exe (a Windows app). The latter is useful from
desktop shortcuts, because error messages are shown in a dialog,
instead of going to stdout/stderr.

             Juanma

Re: saveplace does not work with emacsclient

[P G L Porta Mana]

Thanks for your answer. I use a precompiled version of Emacs (got from
AucTeX website) on a Windows XP machine. There is both an emacsclient.exe
and an emacsclientw.exe binary there. The second eliminates the
appearance of a cmd shell. More can't I say since I don't understand more
than that.

I have temporarily fixed the bug now, by setting

(setq server-visit-hook (quote (save-place-find-file-hook)))

in my .emacs file. I must yet see whether this interferes with inverse
search, ie when emacsclient(w) is called with the +[line] option.

- Luca


On Mon, 07 Jan 2008 08:41:33 -0800
Karl Fogel <kfogel@red-bean.com> wrote:

> P G L  Porta Mana <porta.mana@gmail.com> writes:
> > Although saveplace-mode is activated by default, in files opened
> > through emacsclientw the point appears at the beginning of buffer.
> >
> > This was tested with the following simple .emacs file:
> >
> >  (server-start)
> >  (setq-default save-place t)
> >  (require 'saveplace)
> 
> Is "emacsclientw" a typo for "emacsclient", or is there some wrapper
> script going on here that I don't know about?
> 
> I will reproduce and debug/fix when I get a chance.  Thanks for the
> report.
> 
> -Karl

Re: saveplace does not work with emacsclient

[Karl Fogel]

P G L  Porta Mana <porta.mana@gmail.com> writes:
> Although saveplace-mode is activated by default, in files opened through
> emacsclientw the point appears at the beginning of buffer.
>
> This was tested with the following simple .emacs file:
>
>  (server-start)
>  (setq-default save-place t)
>  (require 'saveplace)

Is "emacsclientw" a typo for "emacsclient", or is there some wrapper
script going on here that I don't know about?

I will reproduce and debug/fix when I get a chance.  Thanks for the report.

-Karl

Re: saveplace does not work with emacsclient

[P G L Porta Mana]

I wrote:

> I have temporarily fixed the bug now, by setting
> 
> (setq server-visit-hook (quote (save-place-find-file-hook)))
> 
> in my .emacs file. I must yet see whether this interferes with inverse
> search, ie when emacsclient(w) is called with the +[line] option.

No, it doesn't interfere, so it's a good solution for the moment.
Something similar should preferably be present either in saveplace.el or
in server.el.

Cordially,
Piero

Re: saveplace does not work with emacsclient

[Stefan Monnier]

>> I have temporarily fixed the bug now, by setting
>> 
>> (setq server-visit-hook (quote (save-place-find-file-hook)))
>> 
>> in my .emacs file. I must yet see whether this interferes with inverse
>> search, ie when emacsclient(w) is called with the +[line] option.

> No, it doesn't interfere, so it's a good solution for the moment.
> Something similar should preferably be present either in saveplace.el or
> in server.el.

Can you try the patch below (and remove your temporary workaround of
course) and tell us if it fixes the problem?


        Stefan


--- orig/lisp/server.el
+++ mod/lisp/server.el
@@ -805,8 +805,8 @@
                 (tty-name nil)       ;nil, `window-system', or the tty name.
                 tty-type             ;string.
 		(files nil)
-		(lineno 1)
-		(columnno 0)
+		(lineno nil)
+		(columnno nil)
 		command-line-args-left
 		arg)
 	    ;; Remove this line from STRING.
@@ -889,9 +889,10 @@
 		    (setq file (command-line-normalize-file-name file))
 		    (push (list file lineno columnno) files)
 		    (server-log (format "New file: %s (%d:%d)"
-                                        file lineno columnno) proc))
-		  (setq lineno 1
-			columnno 0))
+                                        file (or lineno 0) (or columnno 0))
+                                proc))
+		  (setq lineno nil
+			columnno nil))
 
 		 ;; -eval EXPR:  Evaluate a Lisp expression.
 		 ((and (equal "-eval" arg)
@@ -901,8 +902,8 @@
 			(setq expr (decode-coding-string expr coding-system)))
                     (push (lambda () (server-eval-and-print expr proc))
                           commands)
-		    (setq lineno 1
-			  columnno 0)))
+		    (setq lineno nil
+			  columnno nil)))
 
 		 ;; -env NAME=VALUE:  An environment variable.
 		 ((and (equal "-env" arg) command-line-args-left)
@@ -995,10 +996,11 @@
   "Move point to the position indicated in FILE-LINE-COL.
 FILE-LINE-COL should be a three-element list as described in
 `server-visit-files'."
-  (goto-line (nth 1 file-line-col))
-  (let ((column-number (nth 2 file-line-col)))
-    (when (> column-number 0)
-      (move-to-column (1- column-number)))))
+  (when (nth 1 file-line-col)
+    (goto-line (nth 1 file-line-col))
+    (let ((column-number (nth 2 file-line-col)))
+      (when (> column-number 0)
+        (move-to-column (1- column-number))))))
 
 (defun server-visit-files (files proc &optional nowait)
   "Find FILES and return a list of buffers created.