From: Nico Golde <nico@ngolde.de>
To: bug-gnu-emacs@gnu.org
Subject: some code issues
Date: Sat, 5 Jan 2008 18:59:08 +0100 [thread overview]
Message-ID: <20080105175908.GA31673@ngolde.de> (raw)
[-- Attachment #1: Type: text/plain, Size: 1678 bytes --]
Hi,
I had a quick look at the pop.c code today and found some
issues.
In pop_stat:
365 if (strncmp (fromserver, "+OK ", 4))
366 {
367 if (0 == strncmp (fromserver, "-ERR", 4))
368 {
369 strncpy (pop_error, fromserver, ERROR_MAX);
370 }
371 else
372 {
373 strcpy (pop_error,
374 >··· "Unexpected response from POP server in pop_stat");
375 pop_trash (server);
376 }
377 return (-1);
378 }
380 *count = atoi (&fromserver[4]);
381
382 fromserver = index (&fromserver[4], ' ');
383 if (! fromserver)
384 {
385 strcpy (pop_error,
386 >··· "Badly formatted response from server in pop_stat");
387 pop_trash (server);
388 return (-1);
389 }
If I don't miss anything the atoi call in 380 is not save as it is not
save because it is not ensure that &fromserver[4] is not NULL. A crafted
pop3 server could thus crash emacs. This is of course not a real issue but
wouldn't be nice. Same for the pop_last function.
In pop_list:
440
441 *IDs = (int *) malloc ((how_many + 1) * sizeof (int));
442 *sizes = (int *) malloc ((how_many + 1) * sizeof (int));
443 if (! (*IDs && *sizes))
444 {
445 strcpy (pop_error, "Out of memory in pop_list");
446 return (-1);
447 }
448
in 441 and 442 there should be some check for how_many to prevent an integer
overflow here.
Same problem for the xnew macro in etags.c
What do you think about this?
Kind regards
Nico
--
Nico Golde - http://www.ngolde.de - nion@jabber.ccc.de - GPG: 0x73647CFF
For security reasons, all text in this mail is double-rot13 encrypted.
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
next reply other threads:[~2008-01-05 17:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-05 17:59 Nico Golde [this message]
2008-01-08 21:26 ` some code issues Thien-Thi Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080105175908.GA31673@ngolde.de \
--to=nico@ngolde.de \
--cc=bug-gnu-emacs@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.