From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Emanuele Giaquinta Newsgroups: gmane.emacs.devel Subject: Re: vc-revision-other-window problem Date: Mon, 17 Dec 2007 11:12:42 +0100 Message-ID: <20071217101242.GA59857@orion.lan> References: <20071217010646.GA56945@orion.lan> <47662BEF.80203@gmx.at> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1197886447 13218 80.91.229.12 (17 Dec 2007 10:14:07 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 17 Dec 2007 10:14:07 +0000 (UTC) Cc: emacs-devel@gnu.org To: martin rudalics Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Dec 17 11:14:19 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1J4CzI-0007bT-GB for ged-emacs-devel@m.gmane.org; Mon, 17 Dec 2007 11:14:17 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1J4Cyy-00019G-Gg for ged-emacs-devel@m.gmane.org; Mon, 17 Dec 2007 05:13:56 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1J4CyQ-0000fs-4g for emacs-devel@gnu.org; Mon, 17 Dec 2007 05:13:22 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1J4CyO-0000eG-F0 for emacs-devel@gnu.org; Mon, 17 Dec 2007 05:13:21 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1J4CyN-0000dz-Tz for emacs-devel@gnu.org; Mon, 17 Dec 2007 05:13:20 -0500 Original-Received: from fk-out-0910.google.com ([209.85.128.185]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1J4CyN-0001PJ-EB for emacs-devel@gnu.org; Mon, 17 Dec 2007 05:13:19 -0500 Original-Received: by fk-out-0910.google.com with SMTP id 26so1399605fkx.10 for ; Mon, 17 Dec 2007 02:13:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:date:from:to:cc:subject:message-id:references:mime-version:content-type:content-disposition:in-reply-to; bh=5jyFWKmkiTHT4hAbtBopkxs/Qr42reo/nGDVbzwGdg8=; b=JjK58VNGEQL5TlyjeCpKqch5YL1YetbPveGsArxASRBklqJ3LIN8/7UIGaMHWB3yrV0a9VGh36ocl4XfRschHzDODdd288f5HHZfPvgEkt/o6IEDVBwqRAQt6PRDPlxZkyF0xmskPdYeWecTXNTtJJxDY0QOeeZYpZeZa03TUp4= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:references:mime-version:content-type:content-disposition:in-reply-to; b=L4vq2Xu9XDTx5rF/yoHBzfy61m7lpFZutW6wkGjmE6yR9/6JJogka0Cp50uNSCqhOSLoTwYgh5pKzfEkH0bbjUDK7mRLuMCQpQ/ws9nrjIXrYPKUoHPwZkyz7wXHl2PwXH+PrUmsTlqsx4ms1Su55hn+Kda/N0z97ryHUMB5GDM= Original-Received: by 10.86.74.15 with SMTP id w15mr2236010fga.9.1197886395477; Mon, 17 Dec 2007 02:13:15 -0800 (PST) Original-Received: from localhost ( [87.17.101.174]) by mx.google.com with ESMTPS id 4sm8849360fge.2007.12.17.02.13.13 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 17 Dec 2007 02:13:14 -0800 (PST) Content-Disposition: inline In-Reply-To: <47662BEF.80203@gmx.at> X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:85211 Archived-At: On Mon, Dec 17, 2007 at 08:57:35AM +0100, martin rudalics wrote: >> in latest cvs vc-revision-other-window hangs in vc-ensure-vc-buffer >> when called for the second time. The problem seems to be the following >> code in vc-ensure-vc-buffer >> >> (while vc-parent-buffer >> (set-buffer vc-parent-buffer)) >> >> the first time it is fine because vc-parent-buffer is nil, but, since >> vc-revision-other-window calls vc-find-revision which sets >> vc-parent-buffer, the second time vc-parent-buffer will have a non nil >> value. Hope the diagnosis is correct. > > Does it work with the attached patch? Which patch? :)