emacsclient -n problems

emacsclient -n problems

[Emanuele Giaquinta]

Hi,

Using latest cvs, with the following recipe:

emacs -Q --eval '(server-start)'
emacsclient -nc
evaluate '(save-buffers-kill-terminal)' in the client

Debugger entered--Lisp error: (wrong-type-argument processp nowait)
  process-plist(nowait)
  process-get(nowait buffers)
  server-save-buffers-kill-terminal(nowait nil)
  save-buffers-kill-terminal()
  eval((save-buffers-kill-terminal))
  eval-expression((save-buffers-kill-terminal) nil)
  call-interactively(eval-expression nil nil)

When using '--no-wait' together with '--tty' instead the client does
not even start.

Emanuele Giaquinta

Re: emacsclient -n problems

[Stefan Monnier]

> Using latest cvs, with the following recipe:

> emacs -Q --eval '(server-start)'
> emacsclient -nc
> evaluate '(save-buffers-kill-terminal)' in the client

> Debugger entered--Lisp error: (wrong-type-argument processp nowait)
>   process-plist(nowait)
>   process-get(nowait buffers)
>   server-save-buffers-kill-terminal(nowait nil)
>   save-buffers-kill-terminal()
>   eval((save-buffers-kill-terminal))
>   eval-expression((save-buffers-kill-terminal) nil)
>   call-interactively(eval-expression nil nil)

> When using '--no-wait' together with '--tty' instead the client does
> not even start.

Thank you for the report.  Looks like a simple bug.  I'll take a look at
it when I come from from my vacation,


        Stefan

Re: emacsclient -n problems

[Stefan Monnier]

> emacs -Q --eval '(server-start)'
> emacsclient -nc
> evaluate '(save-buffers-kill-terminal)' in the client

> Debugger entered--Lisp error: (wrong-type-argument processp nowait)

I've just installed the patch below which should fix this problem.


        Stefan


Index: lisp/server.el
===================================================================
RCS file: /sources/emacs/emacs/lisp/server.el,v
retrieving revision 1.154
diff -u -r1.154 server.el
--- lisp/server.el	10 Dec 2007 03:51:25 -0000	1.154
+++ lisp/server.el	23 Dec 2007 22:43:44 -0000
@@ -1260,12 +1260,16 @@
 
 ;;;###autoload
 (defun server-save-buffers-kill-terminal (proc &optional arg)
+  ;; Called from save-buffers-kill-terminal in files.el.
   "Offer to save each buffer, then kill PROC.
 
 With prefix arg, silently save all file-visiting buffers, then kill.
 
 If emacsclient was started with a list of filenames to edit, then
 only these files will be asked to be saved."
+  ;; save-buffers-kill-terminal occasionally calls us with proc set
+  ;; to `nowait' (comes from the value of the `client' frame parameter).
+  (when (processp proc)
   (let ((buffers (process-get proc 'buffers)))
     ;; If client is bufferless, emulate a normal Emacs session
     ;; exit and offer to save all buffers.  Otherwise, offer to
@@ -1274,7 +1278,7 @@
 		       (if buffers
 			   (lambda () (memq (current-buffer) buffers))
 			 t))
-    (server-delete-client proc)))
+      (server-delete-client proc))))
 
 (define-key ctl-x-map "#" 'server-edit)