Re: [ra5ul@comcast.net: case-insensitive partial-completion-mode issue]

From: "Andreas Röhler" <andreas.roehler@online.de>
To: rms@gnu.org
Cc: emacs-devel@gnu.org
Subject: Re: [ra5ul@comcast.net: case-insensitive partial-completion-mode issue]
Date: Sat, 8 Dec 2007 13:12:35 +0100	[thread overview]
Message-ID: <200712081312.36389.andreas.roehler@online.de> (raw)
In-Reply-To: <E1J0nAw-0005ur-Iw@fencepost.gnu.org>

[-- Attachment #1: Type: text/plain, Size: 887 bytes --]

Am Samstag, 8. Dezember 2007 01:04 schrieb Richard Stallman:
> Does my patch seem correct?
>
> In other words, did it fix part of the problem?
> Did it cause any new problem?
> Basically, should I install it?
>
>
20071208-an-ed.txt

No. It's not there, at least not for this bug.

Meanwhile I think I got the error:

`wildcard-to-regexp' returns always case-sensitive.

Attached the edebug-messages for that part.

Avoiding a call to `wildcard-to-regexp' when
`(directory-files' is called within
`file-expand-wildcards' solves the problem here.

As it's in the core of files.el, I'd hesitate to change
it there. Maybe complete.el should have an own
`file-expand-wildcards'-function?

Attached the diff against CVS files.el so far.

BTW `read-file-name-completion-ignore-case' can't be
saved after customization to `t' with Emacs -Q.

Andreas Röhler

[-- Attachment #2: 20071208-an-ed.txt --]
[-- Type: text/plain, Size: 1058 bytes --]

20071208-an-ed.txt

Result: "F*"
Result: "\\`F[^\0]*\\'"
Result: ("FILE.TXT")

Result: "f*"
Result: "\\`f[^\0]*\\'"
Result: nil
if: Reading directory: datei oder Verzeichnis nicht gefunden, /home/speck/DIR

diff -c MY-PATH/emacs/20071207/emacs/lisp/files.el MY-PATH/progarbeit/emacs/veraendert/files.el
*** MY-PATH/emacs/20071207/emacs/lisp/files.el	2007-12-07 11:13:22.000000000 +0100
--- MY-PATH/progarbeit/emacs/veraendert/files.el	2007-12-08 13:03:37.000000000 +0100
***************
*** 4796,4802 ****
  							 (file-name-nondirectory name))
  				     name))
  			       (directory-files (or (car dirs) ".") full
! 						(wildcard-to-regexp nondir))))))
  	    (setq contents
  		  (nconc
  		   (if (and (car dirs) (not full))
--- 4796,4805 ----
  							 (file-name-nondirectory name))
  				     name))
  			       (directory-files (or (car dirs) ".") full
! 						
! ;;; 						(wildcard-to-regexp nondir)
! 						nondir
! 						)))))
  	    (setq contents
  		  (nconc
  		   (if (and (car dirs) (not full))

Diff finished.  Sat Dec  8 13:03:51 2007

[-- Attachment #3: Type: text/plain, Size: 142 bytes --]

_______________________________________________
Emacs-devel mailing list
Emacs-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-devel