Re: Bogus byte-compiler warnings

[Dan Nicolaescu <dann@ics.uci.edu>]

Reiner Steib <reinersteib+gmane@imap.cc> writes:

  > On Sun, Nov 19 2006, Chong Yidong wrote:
  >         ^^^^^^^^^^^
  > 
  > [ See <http://thread.gmane.org/gmane.emacs.devel/62115> for the
  >   complete thread. ]
  > 
  > > Richard Stallman <rms@gnu.org> writes:
  > >
  > >>     > The reason there is a warning for foo-1 is that the code in the
  > >>     > compiler to avoid such warnings recognizes only the simpler case (such
  > >>     > as foo-2) and not the more complex case that foo-1 is.
  > >>     >
  > >>     > I would not mind if that code were made smarter.
  > >>
  > >>     How bout this patch?
  > >>
  > >> I think it would be better to save this for after the release.
  > >> Changes in this code are somewhat risky, and even if you have
  > >> been rather careful, you could easily break something.
  > >
  > > I had already checked it into CVS (since you put it in FOR-RELEASE, I
  > > assumed you wanted it fixed).  But I agree that now is not the time
  > > for such changes, so I've reverted the change.
  > 
  > The patch below has been reverted because Richard didn't want to
  > install it before the release of Emacs 22.1.  Maybe it should be
  > installed now in the trunk?

The example given at the start of this thread does not produce any
warning now (I fixed it on 2007-11-10). So unless there are other cases
that produce bogus warnings, this patch should not be needed anymore.