From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Eric S. Raymond" Newsgroups: gmane.emacs.devel Subject: Re: 23.0.50; vc-diff needs CVS repository now Date: Sun, 11 Nov 2007 16:06:20 -0500 Organization: Eric Conspiracy Secret Labs Message-ID: <20071111210620.GA7851@thyrsus.com> References: <20071027090527.323938FC6D@kahikatea.snap.net.nz> <20071104174311.GB19187@thyrsus.com> <200711112054.lABKsTj0016411@oogie-boogie.ics.uci.edu> Reply-To: esr@thyrsus.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1194815213 1720 80.91.229.12 (11 Nov 2007 21:06:53 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 11 Nov 2007 21:06:53 +0000 (UTC) Cc: Glenn Morris , Nick Roberts , Emacs developers To: Dan Nicolaescu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Nov 11 22:06:57 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1IrK15-00078u-Lb for ged-emacs-devel@m.gmane.org; Sun, 11 Nov 2007 22:06:51 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IrK0t-00039d-Km for ged-emacs-devel@m.gmane.org; Sun, 11 Nov 2007 16:06:39 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1IrK0r-00039Y-DU for emacs-devel@gnu.org; Sun, 11 Nov 2007 16:06:37 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1IrK0p-00038q-It for emacs-devel@gnu.org; Sun, 11 Nov 2007 16:06:36 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IrK0p-00038n-Gh for emacs-devel@gnu.org; Sun, 11 Nov 2007 16:06:35 -0500 Original-Received: from static-71-162-243-5.phlapa.fios.verizon.net ([71.162.243.5] helo=snark) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1IrK0l-0001Tf-7e; Sun, 11 Nov 2007 16:06:31 -0500 Original-Received: by snark (Postfix, from userid 23) id 0CC8C3807C; Sun, 11 Nov 2007 16:06:21 -0500 (EST) Content-Disposition: inline In-Reply-To: <200711112054.lABKsTj0016411@oogie-boogie.ics.uci.edu> X-Eric-Conspiracy: There is no conspiracy User-Agent: Mutt/1.5.15+20070412 (2007-04-11) X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 2) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:82965 Archived-At: Dan Nicolaescu : > I adapted the old vc-diff-internal logic to vc-cvs-diff. After the > patch below the CVS repository is not needed if backup files are > present. Thanks, Dan. If you have not yet committed this, you have my encouragement to do so. > Not sure what is the "correct" return value for vc-cvs-diff in the > case when the CVS repository is not accessed (i.e. when using plain > "diff" instead of "cvs diff"). Hmmm...probably 0. But even if that's wrong, your logic is still an improvement. -- Eric S. Raymond