summary for the remaining byte compiler warnings

summary for the remaining byte compiler warnings

[Dan Nicolaescu]

Below is the list of byte compiler warnings when bootstrapping
(excluding about 200 unknown function warnings which are hard to fix
without fixing a few bugs in the byte compiler and adding some
features) together with some brief analysis. 
Please help fix these issues.

A patch was posted some time ago for this one:

In toplevel form:
cc-vars.el:158:1:Warning: !! The file uses old-style backquotes !!
This functionality has been obsolete for more than 10 years already
and will be removed soon.  See (elisp)Backquote in the manual.


No idea about this one:

In toplevel form:
pgg-parse.el:183:8:Warning: reference to free variable `pgg-parse-crc24'



These probably need fixing:

In toplevel form:
simple.el:2564:2:Warning: `make-variable-frame-local' is an obsolete function
    (as of Emacs 22.2); use a frame-parameter instead
simple.el:2592:2:Warning: `make-variable-frame-local' is an obsolete function
    (as of Emacs 22.2); use a frame-parameter instead


What's the best way to silence this one?

In tex-mode:
tex-mode.el:910:8:Warning: function `tex-mode' defined multiple times in this
    file


No idea here:

In toplevel form:
cc-subword.el:147:5:Warning: `make-variable-buffer-local' should be called at
    toplevel


Not sure what to do about this:

In cperl-mode:
cperl-mode.el:1793:9:Warning: `vc-header-alist' is an obsolete variable; use
    `vc-BACKEND-header' instead.
cperl-mode.el:1805:25:Warning: reference to free variable
    `compilation-error-regexp-alist'
cperl-mode.el:1806:19:Warning: assignment to free variable
    `compilation-error-regexp-alist'


How about this?

In toplevel form:
python.el:2067:1:Warning: reference to free variable
    `python-mode-abbrev-table'


These probably need fixing:

In toplevel form:
viper-init.el:433:6:Warning: `make-variable-frame-local' is an obsolete
    function (as of Emacs 22.2); use a frame-parameter instead
viper-init.el:440:6:Warning: `make-variable-frame-local' is an obsolete
    function (as of Emacs 22.2); use a frame-parameter instead
viper-init.el:450:6:Warning: `make-variable-frame-local' is an obsolete
    function (as of Emacs 22.2); use a frame-parameter instead
viper-init.el:455:6:Warning: `make-variable-frame-local' is an obsolete
    function (as of Emacs 22.2); use a frame-parameter instead


This looks like it might be a bug in the code:

In reftex-make-separate-toc-frame:
reftex-toc.el:998:35:Warning: `focus-frame' is an obsolete function (as of
    Emacs 22.1); it does nothing.


These are all for gnus:

In gnus-batch-score:
gnus-kill.el:690:11:Warning: `nnmail-spool-file' is an obsolete variable; This
    option is obsolete in Gnus 5.9.  Use `mail-sources' instead.

In nnkiboze-generate-groups:
nnkiboze.el:201:10:Warning: `nnmail-spool-file' is an obsolete variable; This
    option is obsolete in Gnus 5.9.  Use `mail-sources' instead.

In gnus-jog-cache:
gnus-cache.el:623:10:Warning: `nnmail-spool-file' is an obsolete variable;
    This option is obsolete in Gnus 5.9.  Use `mail-sources' instead.

In gnus-display-x-face-in-from:
gnus-fun.el:225:38:Warning: reference to free variable
    `gnus-face-properties-alist'

In gnus-registry-wash-for-keywords:
gnus-registry.el:512:34:Warning: reference to free variable
    `gnus-adaptive-word-syntax-table'

In toplevel form:
gnus.el:2033:28:Warning: reference to free variable `gnus-spam-resend-to'
gnus.el:2051:28:Warning: reference to free variable `gnus-ham-resend-to'

In message-insert-formated-citation-line:
message.el:3706:43:Warning: reference to free variable
    `gnus-extract-address-components'

In toplevel form:
mm-util.el:187:27:Warning: reference to free variable
    `mm-mime-mule-charset-alist'

In mml-smime-get-ldap-cert:
mml-smime.el:205:37:Warning: reference to free variable
    `gnus-extract-address-components'

In mml-mode:
mml.el:1079:20:Warning: reference to free variable `mml-dnd-protocol-alist'

In nnheader-generate-fake-message-id:
nnheader.el:231:33:Warning: reference to free variable `gnus-newsgroup-name'

In nnheader-insert-head:
nnheader.el:619:35:Warning: reference to free variable
    `nnheader-file-coding-system'

Re: summary for the remaining byte compiler warnings

[Stefan Monnier]

> These probably need fixing:

> In toplevel form:
> simple.el:2564:2:Warning: `make-variable-frame-local' is an obsolete function
>     (as of Emacs 22.2); use a frame-parameter instead
> simple.el:2592:2:Warning: `make-variable-frame-local' is an obsolete function
>     (as of Emacs 22.2); use a frame-parameter instead

Yes, but it's not urgent.

> What's the best way to silence this one?

> In tex-mode:
> tex-mode.el:910:8:Warning: function `tex-mode' defined multiple times in this
>     file

No idea (I do know about it since I caused it and decided it was better
than other alternatives, and even convinced Richard of that as well).

> Not sure what to do about this:

> In cperl-mode:
> cperl-mode.el:1793:9:Warning: `vc-header-alist' is an obsolete variable; use
>     `vc-BACKEND-header' instead.
> cperl-mode.el:1805:25:Warning: reference to free variable
>     `compilation-error-regexp-alist'
> cperl-mode.el:1806:19:Warning: assignment to free variable
>     `compilation-error-regexp-alist'

Better leave cperl-mode.el alone unless it's a bug-fix.

> How about this?

> In toplevel form:
> python.el:2067:1:Warning: reference to free variable
>     `python-mode-abbrev-table'

Here the problem is that the byte-compiler doesn't understand that

   (define-abbrev-table 'python-mode-abbrev-table ()
     "Abbrev table for Python mode.
   The default contents correspond to the elements of `python-skeletons'."
     ;; Allow / in abbrevs.
     :regexp "\\<\\([[:word:]/]+\\)\\W*")

defines the `python-mode-abbrev-table' variable.  I believe I've just
fixed it.

> These probably need fixing:

> In toplevel form:
> viper-init.el:433:6:Warning: `make-variable-frame-local' is an obsolete
>     function (as of Emacs 22.2); use a frame-parameter instead
> viper-init.el:440:6:Warning: `make-variable-frame-local' is an obsolete
>     function (as of Emacs 22.2); use a frame-parameter instead
> viper-init.el:450:6:Warning: `make-variable-frame-local' is an obsolete
>     function (as of Emacs 22.2); use a frame-parameter instead
> viper-init.el:455:6:Warning: `make-variable-frame-local' is an obsolete
>     function (as of Emacs 22.2); use a frame-parameter instead

Even less urgent.


        Stefan

Re: summary for the remaining byte compiler warnings

[Dan Nicolaescu]

Stefan Monnier <monnier@iro.umontreal.ca> writes:

  > > How about this?
  > 
  > > In toplevel form:
  > > python.el:2067:1:Warning: reference to free variable
  > >     `python-mode-abbrev-table'
  > 
  > Here the problem is that the byte-compiler doesn't understand that
  > 
  >    (define-abbrev-table 'python-mode-abbrev-table ()
  >      "Abbrev table for Python mode.
  >    The default contents correspond to the elements of `python-skeletons'."
  >      ;; Allow / in abbrevs.
  >      :regexp "\\<\\([[:word:]/]+\\)\\W*")
  > 
  > defines the `python-mode-abbrev-table' variable.  I believe I've just
  > fixed it.

Shouldn't define-abbrev-table also get font-lock support?