From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dan Nicolaescu Newsgroups: gmane.emacs.devel Subject: Re: Problems setting byte-compile-warnings to t Date: Mon, 29 Oct 2007 11:39:43 -0700 Message-ID: <200710291839.l9TIdhBc006406@oogie-boogie.ics.uci.edu> References: <9p8x5qiwik.fsf@fencepost.gnu.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1193683394 4940 80.91.229.12 (29 Oct 2007 18:43:14 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 29 Oct 2007 18:43:14 +0000 (UTC) Cc: rms@gnu.org, emacs-devel@gnu.org To: Glenn Morris Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Oct 29 19:43:16 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1ImZZx-0000bz-8d for ged-emacs-devel@m.gmane.org; Mon, 29 Oct 2007 19:43:13 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1ImZZo-0002DL-0M for ged-emacs-devel@m.gmane.org; Mon, 29 Oct 2007 14:43:04 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1ImZZj-0002Av-Ti for emacs-devel@gnu.org; Mon, 29 Oct 2007 14:42:59 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1ImZZi-00028o-CU for emacs-devel@gnu.org; Mon, 29 Oct 2007 14:42:59 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1ImZZi-00028i-7k for emacs-devel@gnu.org; Mon, 29 Oct 2007 14:42:58 -0400 Original-Received: from oogie-boogie.ics.uci.edu ([128.195.1.41]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1ImZZY-0003Xt-TF; Mon, 29 Oct 2007 14:42:49 -0400 Original-Received: from mothra.ics.uci.edu (mothra.ics.uci.edu [128.195.6.93]) by oogie-boogie.ics.uci.edu (8.13.6/8.13.6) with ESMTP id l9TIdhBc006406; Mon, 29 Oct 2007 11:39:43 -0700 (PDT) In-Reply-To: (Glenn Morris's message of "Sun\, 28 Oct 2007 19\:58\:54 -0400") Original-Lines: 32 X-ICS-MailScanner: Found to be clean X-ICS-MailScanner-SpamCheck: not spam, SpamAssassin (score=-1.44, required 5, autolearn=disabled, ALL_TRUSTED -1.44) X-ICS-MailScanner-From: dann@mothra.ics.uci.edu X-detected-kernel: by monty-python.gnu.org: Solaris 9 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:82085 Archived-At: Glenn Morris writes: > Richard Stallman wrote: > > > So the simplest fix would seem to adjust the buffer-local value in > > inbuffer in the same way that byte-compile-close-variables does. > > > > I see a problem with that: such a change would persist after the end > > of the compilation. > > Yes, but in an internal buffer used only by byte-compilation, so I > don't see the problem. Anyway... > > > Here's another idea: add a function byte-compile-memq which always > > returns t if the second arg is t, and use that instead of memq to test > > membership in byte-compile-warnings. That avoids the need to alter > > data provided by the user. > > I installed a changes along these lines: byte-compile-warning-enabled-p. > > I also took the opportunity to allow byte-compile-warnings to specify > a list of warnings to _disable_. Useful for compiling emacs-lisp/cl-*, IMO. To take advantage of this new flags I added a new flag to lisp/Makefile.in: BYTE_COMPILE_EXTRA_FLAGS It is empty by default, and it is passed to the byte compiler. It can be used like this: make bootstrap BYTE_COMPILE_EXTRA_FLAGS="--eval '(setq byte-compile-warnings (quote (not unresolved)))'" to not show the hundreds of undefined function warnings, this makes it easier to look for other warnings until a solution is found for undefined function warnings...