From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dan Nicolaescu Newsgroups: gmane.emacs.devel Subject: Re: finish version test cleanup: Lucid Date: Sun, 28 Oct 2007 17:45:13 -0700 Message-ID: <200710290045.l9T0jDrl006236@oogie-boogie.ics.uci.edu> References: <200710281747.l9SHlHL1026263@oogie-boogie.ics.uci.edu> <4724ECDF.3080806@ig.com.br> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1193618760 11288 80.91.229.12 (29 Oct 2007 00:46:00 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 29 Oct 2007 00:46:00 +0000 (UTC) Cc: emacs-devel@gnu.org To: jay.p.belanger@gmail.com Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Oct 29 01:46:02 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1ImIlT-00036T-FB for ged-emacs-devel@m.gmane.org; Mon, 29 Oct 2007 01:45:59 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1ImIlK-0006LM-A2 for ged-emacs-devel@m.gmane.org; Sun, 28 Oct 2007 20:45:50 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1ImIlH-0006Kx-2X for emacs-devel@gnu.org; Sun, 28 Oct 2007 20:45:47 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1ImIlF-0006Ki-Dc for emacs-devel@gnu.org; Sun, 28 Oct 2007 20:45:46 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1ImIlF-0006Kf-AF for emacs-devel@gnu.org; Sun, 28 Oct 2007 20:45:45 -0400 Original-Received: from oogie-boogie.ics.uci.edu ([128.195.1.41]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1ImIlE-0007R0-Qg for emacs-devel@gnu.org; Sun, 28 Oct 2007 20:45:45 -0400 Original-Received: from mothra.ics.uci.edu (mothra.ics.uci.edu [128.195.6.93]) by oogie-boogie.ics.uci.edu (8.13.6/8.13.6) with ESMTP id l9T0jDrl006236; Sun, 28 Oct 2007 17:45:13 -0700 (PDT) In-Reply-To: (Jay Belanger's message of "Sun\, 28 Oct 2007 19\:34\:54 -0500") Original-Lines: 20 X-ICS-MailScanner: Found to be clean X-ICS-MailScanner-SpamCheck: not spam, SpamAssassin (score=-1.44, required 5, autolearn=disabled, ALL_TRUSTED -1.44) X-ICS-MailScanner-From: dann@mothra.ics.uci.edu X-detected-kernel: by monty-python.gnu.org: Solaris 9 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:82013 Archived-At: Jay Belanger writes: > Glenn Morris writes: > ... > >>> ./calc/calc.el:825:(defvar calc-emacs-type-lucid (not (not (string-match "Lucid" emacs-version)))) > > > > Don't know. > > No XEmacs support has been removed from Emacs's Calc, but none has been > added as new features have been added, so I don't know if the current > version will work with XEmacs. XEmacs has it's own version of Calc, > although I don't think it has been updated for a while. That is fine. Is the goal of that code to test if calc is running on XEmacs? If yes, then replacing calc-emacs-type-lucid with (featurep 'xemacs) is better. The featurep test can be completely optimized away at compile time, and it is as readable an a tiny bit shorter. Doing that will make the byte compiler not to warn about missing XEmacs functions.