Re: doc-view compilation warnings

[Dan Nicolaescu <dann@ics.uci.edu>]

Tassilo Horn <tassilo@member.fsf.org> writes:

  > Dan Nicolaescu <dann@ics.uci.edu> writes:
  > 
  > Hi Dan,
  > 
  > > Please add ChangeLog entries when sending patches. 
  > 
  > The patch contains ChangeLog entries.  (The last part of it.)

It is not a good idea to do the add the ChangeLog entry as a diff, it
rarely still applies cleanly at the time it is checked in.
Include it as plain text before that patch, so that it is easier to
see what the patch is about.

  > >   > The patch is also at http://www.tsdh.de/stuff/doc-view.patch
  > >   > 
  > >   > --- lisp/files.el	21 Oct 2007 10:48:28 -0000	1.936
  > >   > +++ lisp/files.el	23 Oct 2007 12:53:00 -0000
  > >   > @@ -2060,7 +2060,8 @@
  > >   >       ("\\.\\(diffs?\\|patch\\|rej\\)\\'" . diff-mode)
  > >   >       ("\\.\\(dif\\|pat\\)\\'" . diff-mode) ; for MSDOG
  > >   >       ("\\.[eE]?[pP][sS]\\'" . ps-mode)
  > >   > -     ("\\.\\(?:PDF\\|DVI\\|pdf\\|dvi\\)" . doc-view-mode)
  > >   > +     ("\\.[Pp][Dd][Ff]\\'" . ps-mode)
  > >   > +     ("\\.[Dd][Vv][Ii]\\'" . fundamental-mode)
  > >   >       ("configure\\.\\(ac\\|in\\)\\'" . autoconf-mode)
  > >   >       ("BROWSE\\'" . ebrowse-tree-mode)
  > >   >       ("\\.ebrowse\\'" . ebrowse-tree-mode)
  > >   > Index: lisp/doc-view.el
  > >   > ===================================================================
  > >   > RCS file: /sources/emacs/emacs/lisp/doc-view.el,v
  > >   > retrieving revision 1.11
  > >   > diff -u -r1.11 doc-view.el
  > >   > --- lisp/doc-view.el	19 Oct 2007 16:03:09 -0000	1.11
  > >   > +++ lisp/doc-view.el	23 Oct 2007 12:53:01 -0000
  > >   > @@ -104,6 +104,10 @@
  > >   >  (require 'image-mode)
  > >   >  (eval-when-compile (require 'cl))
  > >   >  
  > >   > +;;;###autoload (push '("\\.[eE]?[pP][sS]\\'" . doc-view-mode-maybe) auto-mode-alist)
  > >   > +;;;###autoload (push '("\\.[Dd][Vv][Ii]\\'"  . doc-view-mode-maybe) auto-mode-alist)
  > >   > +;;;###autoload (push '("\\.[Pp][Dd][Ff]\\'"  . doc-view-mode-maybe) auto-mode-alist)
  > >
  > > Given that you are changing auto-mode-alist alist directly, why not
  > > put all the auto-mode-alist manipulation in files.el? It's a bit
  > > confusing to see this done in 2 places.
  > 
  > This way it only affects users that want to use doc-view (by requiring
  > it explicitly).  If we say that it should be loaded by default, then I
  > agree with you.  But I'm sure there are a lot people that prefer it not
  > to be loaded by default.

I am not sure I get what you are trying to say. Adding autoloads like
that will result that code to be loaded by default...