From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dan Nicolaescu Newsgroups: gmane.emacs.devel Subject: Re: doc-view compilation warnings Date: Tue, 23 Oct 2007 07:30:46 -0700 Message-ID: <200710231430.l9NEUk8x012690@oogie-boogie.ics.uci.edu> References: <87wsth6vk5.fsf@catnip.gol.com> <878x5wrgnv.fsf@baldur.tsdh.de> <87prz6yn1c.fsf@baldur.tsdh.de> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1193150020 10770 80.91.229.12 (23 Oct 2007 14:33:40 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 23 Oct 2007 14:33:40 +0000 (UTC) Cc: emacs-devel@gnu.org To: rms@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Oct 23 16:33:39 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1IkKp2-00049F-4T for ged-emacs-devel@m.gmane.org; Tue, 23 Oct 2007 16:33:32 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IkKou-0006M3-4b for ged-emacs-devel@m.gmane.org; Tue, 23 Oct 2007 10:33:24 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1IkKor-0006La-HN for emacs-devel@gnu.org; Tue, 23 Oct 2007 10:33:21 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1IkKon-0006K8-JI for emacs-devel@gnu.org; Tue, 23 Oct 2007 10:33:20 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IkKon-0006K5-Dy for emacs-devel@gnu.org; Tue, 23 Oct 2007 10:33:17 -0400 Original-Received: from oogie-boogie.ics.uci.edu ([128.195.1.41]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1IkKoi-00026Z-P9; Tue, 23 Oct 2007 10:33:13 -0400 Original-Received: from mothra.ics.uci.edu (mothra.ics.uci.edu [128.195.6.93]) by oogie-boogie.ics.uci.edu (8.13.6/8.13.6) with ESMTP id l9NEUk8x012690; Tue, 23 Oct 2007 07:30:46 -0700 (PDT) In-Reply-To: <87prz6yn1c.fsf@baldur.tsdh.de> (Tassilo Horn's message of "Tue\, 23 Oct 2007 15\:32\:15 +0200") Original-Lines: 52 X-ICS-MailScanner: Found to be clean X-ICS-MailScanner-SpamCheck: not spam, SpamAssassin (score=-0.84, required 5, autolearn=disabled, ALL_TRUSTED -1.44, J_CHICKENPOX_52 0.60) X-ICS-MailScanner-From: dann@mothra.ics.uci.edu X-detected-kernel: by monty-python.gnu.org: Solaris 9 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:81565 Archived-At: Tassilo Horn writes: > Richard Stallman writes: > > > Yes, I know. I'll fix those after my latest patch got applied. > > So what is the convention? Is calling a cl-function at runtime > > strictly forbidden? > > > > Yes. > > Ok, this patch fixes this issue plus the "open dvi/pdf files with > doc-view and ps-files with ps-mode by default" issue. (See message > <877ilj45zn.fsf@baldur.tsdh.de> and its follow-ups.) > > The only thing that remains is to find another keybinding for toggling > between editing and viewing with doc-view, because ps-mode already uses > `C-c C-c'. Suggestions? Please add ChangeLog entries when sending patches. > The patch is also at http://www.tsdh.de/stuff/doc-view.patch > > --- lisp/files.el 21 Oct 2007 10:48:28 -0000 1.936 > +++ lisp/files.el 23 Oct 2007 12:53:00 -0000 > @@ -2060,7 +2060,8 @@ > ("\\.\\(diffs?\\|patch\\|rej\\)\\'" . diff-mode) > ("\\.\\(dif\\|pat\\)\\'" . diff-mode) ; for MSDOG > ("\\.[eE]?[pP][sS]\\'" . ps-mode) > - ("\\.\\(?:PDF\\|DVI\\|pdf\\|dvi\\)" . doc-view-mode) > + ("\\.[Pp][Dd][Ff]\\'" . ps-mode) > + ("\\.[Dd][Vv][Ii]\\'" . fundamental-mode) > ("configure\\.\\(ac\\|in\\)\\'" . autoconf-mode) > ("BROWSE\\'" . ebrowse-tree-mode) > ("\\.ebrowse\\'" . ebrowse-tree-mode) > Index: lisp/doc-view.el > =================================================================== > RCS file: /sources/emacs/emacs/lisp/doc-view.el,v > retrieving revision 1.11 > diff -u -r1.11 doc-view.el > --- lisp/doc-view.el 19 Oct 2007 16:03:09 -0000 1.11 > +++ lisp/doc-view.el 23 Oct 2007 12:53:01 -0000 > @@ -104,6 +104,10 @@ > (require 'image-mode) > (eval-when-compile (require 'cl)) > > +;;;###autoload (push '("\\.[eE]?[pP][sS]\\'" . doc-view-mode-maybe) auto-mode-alist) > +;;;###autoload (push '("\\.[Dd][Vv][Ii]\\'" . doc-view-mode-maybe) auto-mode-alist) > +;;;###autoload (push '("\\.[Pp][Dd][Ff]\\'" . doc-view-mode-maybe) auto-mode-alist) Given that you are changing auto-mode-alist alist directly, why not put all the auto-mode-alist manipulation in files.el? It's a bit confusing to see this done in 2 places.