From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dan Nicolaescu Newsgroups: gmane.emacs.devel Subject: Re: verilog-mode.el Date: Sun, 14 Oct 2007 10:49:43 -0700 Message-ID: <200710141749.l9EHnhgA022464@oogie-boogie.ics.uci.edu> References: <47111236.5020402@verilog.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1192384300 26172 80.91.229.12 (14 Oct 2007 17:51:40 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 14 Oct 2007 17:51:40 +0000 (UTC) Cc: emacs-devel@gnu.org, Wilson Snyder To: mac@brushroad.com Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Oct 14 19:51:29 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1Ih7bR-0005qk-KG for ged-emacs-devel@m.gmane.org; Sun, 14 Oct 2007 19:50:13 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Ih7bK-0005M7-V3 for ged-emacs-devel@m.gmane.org; Sun, 14 Oct 2007 13:50:06 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Ih7bH-0005KJ-FQ for emacs-devel@gnu.org; Sun, 14 Oct 2007 13:50:03 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Ih7bE-0005JW-QZ for emacs-devel@gnu.org; Sun, 14 Oct 2007 13:50:03 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Ih7bE-0005JP-JC for emacs-devel@gnu.org; Sun, 14 Oct 2007 13:50:00 -0400 Original-Received: from oogie-boogie.ics.uci.edu ([128.195.1.41]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Ih7bE-0002Bb-1w for emacs-devel@gnu.org; Sun, 14 Oct 2007 13:50:00 -0400 Original-Received: from mothra.ics.uci.edu (mothra.ics.uci.edu [128.195.6.93]) by oogie-boogie.ics.uci.edu (8.13.6/8.13.6) with ESMTP id l9EHnhgA022464; Sun, 14 Oct 2007 10:49:43 -0700 (PDT) In-Reply-To: <47111236.5020402@verilog.com> (Michael McNamara's message of "Sat\, 13 Oct 2007 11\:45\:10 -0700") Original-Lines: 37 X-ICS-MailScanner: Found to be clean X-ICS-MailScanner-SpamCheck: not spam, SpamAssassin (score=-0.34, required 5, autolearn=disabled, ALL_TRUSTED -1.44, FM_MULTI_ODD2 1.10) X-ICS-MailScanner-From: dann@mothra.ics.uci.edu X-detected-kernel: by monty-python.gnu.org: Solaris 9 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:80857 Archived-At: Michael McNamara writes: Thank you for your contribution: > > ;; verilog-mode.el --- major mode for editing verilog source in Emacs > ;; > ;; $Id: verilog-mode.el 366 2007-10-07 13:20:47Z mac $ Keyword expansion frowned on in emacs CVS, it generates unnecessary conflicts... > ;; This variable will always hold the version number of the mode > (defconst verilog-mode-version (substring "$$Revision: 366 $$" 12 -3) > "Version of this verilog mode.") > (defconst verilog-mode-release-date (substring "$$Date: 2007-10-07 06:20:47 -0700 (Sun, 07 Oct 2007) $$" 8 -3) > "Version of this verilog mode.") Same here. > (defvar verilog-mode-map () > "Keymap used in Verilog mode.") > (if verilog-mode-map > () > (setq verilog-mode-map (make-sparse-keymap)) > (define-key verilog-mode-map ";" 'electric-verilog-semi) Better use: (defvar verilog-mode-map (let ((map (make-sparse-keymap))) (define-key map ";" 'electric-verilog-semi) ... etc etc Please look at the byte-compile warnings, most of them are easily fixable.