From: Alan Mackenzie <acm@muc.de>
To: Adrian Robert <adrian.b.robert@gmail.com>
Cc: bug-cc-mode@gnu.org, emacs-devel@gnu.org
Subject: Re: cc-mode enhancement for Objective-C
Date: Sun, 14 Oct 2007 08:29:37 +0000 [thread overview]
Message-ID: <20071014082937.GA2368@muc.de> (raw)
In-Reply-To: <55f7df060710132308t6cb0d145taea3a916e19d6896@mail.gmail.com>
Hi, Adrian,
On Sun, Oct 14, 2007 at 09:08:36AM +0300, Adrian Robert wrote:
> On 10/14/07, Alan Mackenzie <acm@muc.de> wrote:
> > Could I ask you two little favours?
> > (i) Please prefix the names of all the variables with "c-"; e.g., change
> > objc-method-arg-min-delta-to-bracket to
> > c-objc-method-arg-min-delta-to-bracket.
> OK.. it's been a while since I did this patch, so I'm not sure, I
> think I may have been following the naming of "objc-method-intro",
> "objc-method-args-cont", "objc-method-call-count" in cc-vars. However
> I see these seem to be a different type of variable.
`objc-method-intro' is a just a symbol, not a variable. It means "the
line you pressed C-c C-s on is 'The first line of an Objective-C method
definition'". These symbols are documented in the manual (CC Mode 5.31
version) on the page "Syntactic Symbols".
> So the different naming convention should be used? Or is it best to
> change the older three variables to 'c-objc-...'?
"c-" is the naming prefix for _all_ variables and functions within CC
Mode, with the exception of (most of) the mode names c++-mode, objc-mode,
.....
> For now, here is a context diff version of the patch as-is.
Many thanks! That's a lot easier to look at. One thing I forgot to ask
you for is a test case - a little file.m, perhaps ~10 lines long, which
exercises the new indentation and fontification. This will then become
part of the CC Mode test suite. If you're not familiar with this, have a
look at some of the files in:
<http://cc-mode.cvs.sourceforge.net/cc-mode/cc-mode/tests/>.
> -Adrian
--
Alan.
prev parent reply other threads:[~2007-10-14 8:29 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-13 6:43 cc-mode enhancement for Objective-C Adrian Robert
2007-10-13 19:48 ` Richard Stallman
2007-10-14 5:49 ` Adrian Robert
2007-10-15 1:36 ` Richard Stallman
2007-10-15 15:35 ` Adrian Robert
2007-10-17 11:12 ` Adrian Robert
2007-10-17 20:49 ` Richard Stallman
2007-10-23 6:33 ` Adrian Robert
[not found] ` <55f7df060711230243i27c14a3fj44cce23ec26d76e8@mail.gmail.com>
2008-03-05 5:01 ` Adrian Robert
2007-10-13 21:13 ` Alan Mackenzie
2007-10-14 6:08 ` Adrian Robert
2007-10-14 6:10 ` Adrian Robert
2007-10-14 8:29 ` Alan Mackenzie [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071014082937.GA2368@muc.de \
--to=acm@muc.de \
--cc=adrian.b.robert@gmail.com \
--cc=bug-cc-mode@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.