log-view.el calls non-existent function vc-version-diff

log-view.el calls non-existent function vc-version-diff

[Chris Moore]

The only 2 references to vc-version-diff in the whole lisp/ tree are:

./log-view.el:(autoload 'vc-version-diff "vc")
./log-view.el:    (vc-version-diff (log-view-current-file) to fr)))

So generating a log of a controlled file ("C-x v l") and asking for a
diff ("d") errors:

Debugger entered--Lisp error: (error "Autoloading failed to define
function vc-version-diff")
  vc-version-diff("/home/chris/programs/emacs/lisp/log-view.el" "1.45" "1.46")
  log-view-diff(2537 2537)

Re: log-view.el calls non-existent function vc-version-diff

[Dan Nicolaescu]

"Chris Moore" <christopher.ian.moore@gmail.com> writes:

  > The only 2 references to vc-version-diff in the whole lisp/ tree are:
  > 
  > ./log-view.el:(autoload 'vc-version-diff "vc")
  > ./log-view.el:    (vc-version-diff (log-view-current-file) to fr)))

It seems that it should be changed to call vc-history-diff. 

But vc-history-diff takes a `backend' parameter. But it computes the
backend in the code anyway...

ESR, can you please say what is your intention with that function?
Should it just lose the `backend' parameter?

Re: log-view.el calls non-existent function vc-version-diff

[Stefan Monnier]

>> The only 2 references to vc-version-diff in the whole lisp/ tree are:
>> 
>> ./log-view.el:(autoload 'vc-version-diff "vc")
>> ./log-view.el:    (vc-version-diff (log-view-current-file) to fr)))

> It seems that it should be changed to call vc-history-diff. 

> But vc-history-diff takes a `backend' parameter. But it computes the
> backend in the code anyway...

> ESR, can you please say what is your intention with that function?
> Should it just lose the `backend' parameter?

In any case, vc.el should provide a backward compatibility definition of
vc-version-diff (and mark it obsolete).


        Stefan