From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Eric S. Raymond" Newsgroups: gmane.emacs.devel Subject: Re: New VC mode -- review request Date: Tue, 9 Oct 2007 13:21:03 -0400 Organization: Eric Conspiracy Secret Labs Message-ID: <20071009172102.GA4993@thyrsus.com> References: <20071003103501.GA4997@thyrsus.com> <200710031431.l93EVfFZ021233@oogie-boogie.ics.uci.edu> <20071003170048.GB7014@thyrsus.com> <200710040042.l940g1B6012034@oogie-boogie.ics.uci.edu> <20071004020219.GB12134@thyrsus.com> <200710040214.l942EUNr013619@oogie-boogie.ics.uci.edu> <20071009145523.GA3678@thyrsus.com> <200710091533.l99FX4kJ028467@oogie-boogie.ics.uci.edu> Reply-To: esr@thyrsus.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1191950463 20328 80.91.229.12 (9 Oct 2007 17:21:03 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Tue, 9 Oct 2007 17:21:03 +0000 (UTC) Cc: emacs-devel@gnu.org To: Dan Nicolaescu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Oct 09 19:21:00 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1IfIlD-0001Dw-Gi for ged-emacs-devel@m.gmane.org; Tue, 09 Oct 2007 19:20:47 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IfIl7-0001Rf-Ek for ged-emacs-devel@m.gmane.org; Tue, 09 Oct 2007 13:20:41 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1IfIl3-0001Qi-NW for emacs-devel@gnu.org; Tue, 09 Oct 2007 13:20:37 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1IfIl2-0001Pm-BO for emacs-devel@gnu.org; Tue, 09 Oct 2007 13:20:36 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IfIl2-0001Pj-6d for emacs-devel@gnu.org; Tue, 09 Oct 2007 13:20:36 -0400 Original-Received: from static-71-162-243-5.phlapa.fios.verizon.net ([71.162.243.5] helo=snark) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1IfIl1-0004EF-UC for emacs-devel@gnu.org; Tue, 09 Oct 2007 13:20:36 -0400 Original-Received: by snark (Postfix, from userid 23) id 1E77538032; Tue, 9 Oct 2007 13:21:03 -0400 (EDT) Content-Disposition: inline In-Reply-To: <200710091533.l99FX4kJ028467@oogie-boogie.ics.uci.edu> X-Eric-Conspiracy: There is no conspiracy User-Agent: Mutt/1.5.15+20070412 (2007-04-11) X-Detected-Kernel: Linux 2.6 (newer, 2) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:80472 Archived-At: Dan Nicolaescu : > > That's correct, because the visited file isn't under version control. > > That would be a change in long standing behavior, and it is > inconsistent with with to docstring for vc-next-action: " If every > file is not already registered, this registers each one for version > control. This does an add, but not a commit." > IMO this behavior is one of the strengths of vc: C-x v v always does TRT. Actually, I agree with you -- that's how I originally wrote C-x v v, and with that DTRT intention. But somebody broke that feature of vc-next-action years ago, and I've been trying to be very conservative about not bundling into new VC behavioral changes that weren't directly related to the fileset stuff. > Sure, just let's make sure it does not get forgotten. Since it's the way I originally wanted the mode to work, it won't be :-) > Another post merge issue: > The code that deals with registering in vc-next-action: > ;; Files aren't registered > ((not state) > (mapc 'vc-register files)) > > Maybe vc-register could work on a list of files? vc-BACKEND-register > already does that.. Noted. I'll start keeping a to-do list. -- Eric S. Raymond