From: "Eric S. Raymond" <esr@thyrsus.com>
To: Dan Nicolaescu <dann@ics.uci.edu>
Cc: emacs-devel@gnu.org
Subject: Re: New VC mode -- review request
Date: Tue, 9 Oct 2007 13:21:03 -0400 [thread overview]
Message-ID: <20071009172102.GA4993@thyrsus.com> (raw)
In-Reply-To: <200710091533.l99FX4kJ028467@oogie-boogie.ics.uci.edu>
Dan Nicolaescu <dann@ics.uci.edu>:
> > That's correct, because the visited file isn't under version control.
>
> That would be a change in long standing behavior, and it is
> inconsistent with with to docstring for vc-next-action: " If every
> file is not already registered, this registers each one for version
> control. This does an add, but not a commit."
> IMO this behavior is one of the strengths of vc: C-x v v always does TRT.
Actually, I agree with you -- that's how I originally wrote C-x v v, and
with that DTRT intention. But somebody broke that feature of vc-next-action
years ago, and I've been trying to be very conservative about not
bundling into new VC behavioral changes that weren't directly related
to the fileset stuff.
> Sure, just let's make sure it does not get forgotten.
Since it's the way I originally wanted the mode to work, it won't be :-)
> Another post merge issue:
> The code that deals with registering in vc-next-action:
> ;; Files aren't registered
> ((not state)
> (mapc 'vc-register files))
>
> Maybe vc-register could work on a list of files? vc-BACKEND-register
> already does that..
Noted. I'll start keeping a to-do list.
--
<a href="http://www.catb.org/~esr/">Eric S. Raymond</a>
next prev parent reply other threads:[~2007-10-09 17:21 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-03 10:35 New VC mode -- review request Eric S. Raymond
2007-10-03 14:31 ` Dan Nicolaescu
2007-10-03 17:00 ` Eric S. Raymond
2007-10-04 0:42 ` Dan Nicolaescu
2007-10-04 2:02 ` Eric S. Raymond
2007-10-04 2:14 ` Dan Nicolaescu
2007-10-09 14:55 ` Eric S. Raymond
2007-10-09 15:33 ` Dan Nicolaescu
2007-10-09 17:21 ` Eric S. Raymond [this message]
2007-10-04 7:18 ` Thien-Thi Nguyen
2007-10-03 21:32 ` Alexandru Harsanyi
2007-10-04 2:24 ` Dan Nicolaescu
2007-10-04 9:46 ` Alexandru Harsanyi
2007-10-04 9:51 ` Eli Zaretskii
2007-10-04 17:27 ` Richard Stallman
2007-10-04 20:32 ` David Kastrup
2007-10-04 2:02 ` Richard Stallman
2007-10-04 2:22 ` Eric S. Raymond
2007-10-05 16:12 ` Richard Stallman
-- strict thread matches above, loose matches on Subject: below --
2007-10-05 12:15 Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071009172102.GA4993@thyrsus.com \
--to=esr@thyrsus.com \
--cc=dann@ics.uci.edu \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.