From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Eric S. Raymond" Newsgroups: gmane.emacs.devel Subject: Re: New VC mode -- review request Date: Tue, 9 Oct 2007 10:55:24 -0400 Organization: Eric Conspiracy Secret Labs Message-ID: <20071009145523.GA3678@thyrsus.com> References: <20071003103501.GA4997@thyrsus.com> <200710031431.l93EVfFZ021233@oogie-boogie.ics.uci.edu> <20071003170048.GB7014@thyrsus.com> <200710040042.l940g1B6012034@oogie-boogie.ics.uci.edu> <20071004020219.GB12134@thyrsus.com> <200710040214.l942EUNr013619@oogie-boogie.ics.uci.edu> Reply-To: esr@thyrsus.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1191941747 29859 80.91.229.12 (9 Oct 2007 14:55:47 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Tue, 9 Oct 2007 14:55:47 +0000 (UTC) Cc: emacs-devel@gnu.org To: Dan Nicolaescu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Oct 09 16:55:36 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1IfGUB-0002Hn-7T for ged-emacs-devel@m.gmane.org; Tue, 09 Oct 2007 16:55:03 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IfGU5-0002R9-91 for ged-emacs-devel@m.gmane.org; Tue, 09 Oct 2007 10:54:57 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1IfGU3-0002Qy-0Z for emacs-devel@gnu.org; Tue, 09 Oct 2007 10:54:55 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1IfGU0-0002Qj-EZ for emacs-devel@gnu.org; Tue, 09 Oct 2007 10:54:53 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IfGU0-0002Qg-BY for emacs-devel@gnu.org; Tue, 09 Oct 2007 10:54:52 -0400 Original-Received: from static-71-162-243-5.phlapa.fios.verizon.net ([71.162.243.5] helo=snark) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1IfGTz-0004IF-Rl for emacs-devel@gnu.org; Tue, 09 Oct 2007 10:54:51 -0400 Original-Received: by snark (Postfix, from userid 23) id B18B538032; Tue, 9 Oct 2007 10:55:24 -0400 (EDT) Content-Disposition: inline In-Reply-To: <200710040214.l942EUNr013619@oogie-boogie.ics.uci.edu> X-Eric-Conspiracy: There is no conspiracy User-Agent: Mutt/1.5.15+20070412 (2007-04-11) X-Detected-Kernel: Linux 2.6 (newer, 2) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:80467 Archived-At: Dan Nicolaescu : > mkdir /tmp/test > mkdir /tmp/test/RCS > cd /tmp/test > cp ~/.emacs 1.el > cp ~/.emacs 2.el > > emacs -q 1.el 2.el > > C-x v i C-x v v for each of the 2 files. After that they should be > writable. Quit emacs. > > echo foo >> 1.el > echo foo >> 2.el > > emacs -q -l vc.el > (where vc.el is your vc.el) > > C-x v d /tmp/test RET > Mark the 2 files. > v u > > > and now that gets an error. Got it. Turns out buffer-modified-p doesn't behave as I expected on the nil value returned from get-file-buffer on a nonexistent file. The fix is trivial. > BTW, I just found another issue: > with the same setup as above, do: > cp ~/.emacs /tmp/test/3.el > > emacs -q -l vc.el /tmp/test/3.el > > C-x v v > fails with: "No fileset is available here." That's correct, because the visited file isn't under version control. There's a design argument that maybe something different ought to happen here, but that's an after-the-merge issue. -- Eric S. Raymond