From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Eric S. Raymond" Newsgroups: gmane.emacs.devel Subject: Re: New VC diff for review Date: Tue, 9 Oct 2007 06:31:02 -0400 Organization: Eric Conspiracy Secret Labs Message-ID: <20071009103101.GA2023@thyrsus.com> References: <20071006152353.GA15638@thyrsus.com> <200710061938.l96JcojN020804@oogie-boogie.ics.uci.edu> <20071008225842.GA28748@thyrsus.com> Reply-To: esr@thyrsus.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1191925849 3600 80.91.229.12 (9 Oct 2007 10:30:49 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Tue, 9 Oct 2007 10:30:49 +0000 (UTC) Cc: Dan Nicolaescu , emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Oct 09 12:30:47 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1IfCMO-0002oW-U4 for ged-emacs-devel@m.gmane.org; Tue, 09 Oct 2007 12:30:45 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IfCMI-0004Ia-OB for ged-emacs-devel@m.gmane.org; Tue, 09 Oct 2007 06:30:38 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1IfCME-0004Fw-V1 for emacs-devel@gnu.org; Tue, 09 Oct 2007 06:30:34 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1IfCMD-0004Ca-Ew for emacs-devel@gnu.org; Tue, 09 Oct 2007 06:30:34 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IfCMD-0004CQ-A9 for emacs-devel@gnu.org; Tue, 09 Oct 2007 06:30:33 -0400 Original-Received: from static-71-162-243-5.phlapa.fios.verizon.net ([71.162.243.5] helo=snark) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1IfCMC-0001hJ-Cc for emacs-devel@gnu.org; Tue, 09 Oct 2007 06:30:33 -0400 Original-Received: by snark (Postfix, from userid 23) id 54D6038032; Tue, 9 Oct 2007 06:31:02 -0400 (EDT) Content-Disposition: inline In-Reply-To: X-Eric-Conspiracy: There is no conspiracy User-Agent: Mutt/1.5.15+20070412 (2007-04-11) X-Detected-Kernel: Linux 2.6 (newer, 2) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:80464 Archived-At: Stefan Monnier : > >> One of these vc-diff* functions needs to do (vc-call > >> revision-completion-table file) like vc-version-diff does in order to get > >> completions for versions. > > > There's a conceptual problem here. Remember that new VC operates on > > filesets, not files. If the fileset has more than one member, which file > > should be used to key into the revision completion table? > > What's the problem: pass it the fileset and let the backend decide. Ah, I see. I didn't realize you'd added a back-end method for that. I will modify appropriately. > Merge problem. I "recently" replaced the `if' form by the simpler > `expand-file-name' call. Yes, that's what I figured. I've merged that change into new VC. This is going well. The diff is down to c.1300 lines from the original c.2200, and it looks to me like we'll only need one more round to finish off the merge problems. My remaining tasks before committing the big patch are: 1, Replicate the diffing bug Dan was reporting and fix that. 2. Write the Changelog entries for the big patch. After the merge: 3. Terminology cleanup. At this point I'm leaning towards "working revision" for what had previously been "workfile version" and I then relabeled "focus version". This has the advantage that it is parallel to "working copy", which is Subversion jargon that a couple of more recent systems have kept. 4. VC-Dired speedup. It's still slow, and (at least under Subversion and later systems) it doesn't have to be. -- Eric S. Raymond