all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "Eric S. Raymond" <esr@thyrsus.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: Dan Nicolaescu <dann@ics.uci.edu>, emacs-devel@gnu.org
Subject: Re: New VC diff for review
Date: Tue, 9 Oct 2007 06:31:02 -0400	[thread overview]
Message-ID: <20071009103101.GA2023@thyrsus.com> (raw)
In-Reply-To: <jwvtzp1ukit.fsf-monnier+emacs@gnu.org>

Stefan Monnier <monnier@iro.umontreal.ca>:
> >> One of these vc-diff* functions needs to do (vc-call
> >> revision-completion-table file) like vc-version-diff does in order to get
> >> completions for versions.
> 
> > There's a conceptual problem here.  Remember that new VC operates on
> > filesets, not files.  If the fileset has more than one member, which file
> > should be used  to key into the revision completion table?
> 
> What's the problem: pass it the fileset and let the backend decide.

Ah, I see.  I didn't realize you'd added a back-end method for that.
I will modify appropriately.

> Merge problem.  I "recently" replaced the `if' form by the simpler
> `expand-file-name' call.

Yes, that's what I figured.  I've merged that change into new VC.

This is going well.  The diff is down to c.1300 lines from the original
c.2200, and it looks to me like we'll only need one more round to finish
off the merge problems.

My remaining tasks before committing the big patch are:

1, Replicate the diffing bug Dan was reporting and fix that.

2. Write the Changelog entries for the big patch.

After the merge:

3. Terminology cleanup.  At this point I'm leaning towards "working
revision" for what had previously been "workfile version" and I then
relabeled "focus version".  This has the advantage that it is parallel 
to "working copy", which is Subversion jargon that a couple of more
recent systems have kept.

4. VC-Dired speedup.  It's still slow, and (at least under Subversion 
and later systems) it doesn't have to be.
-- 
		<a href="http://www.catb.org/~esr/">Eric S. Raymond</a>

      reply	other threads:[~2007-10-09 10:31 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-06 15:23 New VC diff for review Eric S. Raymond
2007-10-06 19:38 ` Dan Nicolaescu
2007-10-08 22:58   ` Eric S. Raymond
2007-10-09  1:51     ` Stefan Monnier
2007-10-09 10:31       ` Eric S. Raymond [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071009103101.GA2023@thyrsus.com \
    --to=esr@thyrsus.com \
    --cc=dann@ics.uci.edu \
    --cc=emacs-devel@gnu.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.