From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dan Nicolaescu Newsgroups: gmane.emacs.devel Subject: Re: new VC, current with changes up to 1.456 Date: Wed, 03 Oct 2007 18:10:28 -0700 Message-ID: <200710040110.l941ASto012574@oogie-boogie.ics.uci.edu> References: <20071003192456.GA8963@thyrsus.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1191460378 13059 80.91.229.12 (4 Oct 2007 01:12:58 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Thu, 4 Oct 2007 01:12:58 +0000 (UTC) Cc: emacs-devel@gnu.org To: esr@thyrsus.com Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Oct 04 03:12:55 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1IdFGp-0007BV-82 for ged-emacs-devel@m.gmane.org; Thu, 04 Oct 2007 03:12:55 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IdFGk-0006uK-Hn for ged-emacs-devel@m.gmane.org; Wed, 03 Oct 2007 21:12:50 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1IdFGh-0006rs-4h for emacs-devel@gnu.org; Wed, 03 Oct 2007 21:12:47 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1IdFGg-0006pp-4T for emacs-devel@gnu.org; Wed, 03 Oct 2007 21:12:46 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IdFGf-0006ol-Nv for emacs-devel@gnu.org; Wed, 03 Oct 2007 21:12:45 -0400 Original-Received: from oogie-boogie.ics.uci.edu ([128.195.1.41]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1IdFGf-0000yX-86 for emacs-devel@gnu.org; Wed, 03 Oct 2007 21:12:45 -0400 Original-Received: from mothra.ics.uci.edu (mothra.ics.uci.edu [128.195.6.93]) by oogie-boogie.ics.uci.edu (8.13.6/8.13.6) with ESMTP id l941ASto012574; Wed, 3 Oct 2007 18:10:28 -0700 (PDT) In-Reply-To: <20071003192456.GA8963@thyrsus.com> (Eric S. Raymond's message of "Wed\, 3 Oct 2007 15\:24\:56 -0400") Original-Lines: 39 X-ICS-MailScanner: Found to be clean X-ICS-MailScanner-SpamCheck: not spam, SpamAssassin (score=-0.84, required 5, autolearn=disabled, ALL_TRUSTED -1.44, J_CHICKENPOX_22 0.60) X-ICS-MailScanner-From: dann@mothra.ics.uci.edu X-Detected-Kernel: Solaris 9 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:80212 Archived-At: "Eric S. Raymond" writes: > Also incorporates review suggestions by Dan Nicolaescu. I looked at this new version just for a few things that I know that have changed in vc.el in CVS trunk, they are missing here. Here's a list: For the comment at the beginning of vc.el: - copyright: 2007 missing - $Id$ has appeared - please don't say "new version", it won't be "new" soon enough. - It should be ";; * create-repo ()", not ";; * create-repo (backend)" - ";; - log-view-mode ()" is missing - ";; - revision-completion-table (file)" is missing - diff-tree has disappeared, should it be deleted from all the backends? For the rest: - vc-print-log should call the log-view-mode backend method - vc-default-log-view-mode is missing - vc-annotate-display-select should use vc-select-after - vc-default-revision-completion-table is missing - vc-default-diff-tree mentions vc-version-diff which does not exist anymore - vc-version-other-window should vc-call revision-completion-table - vc-history-diff should vc-call revision-completion-table Given that so many things are missing from the merge, can you please reconsider your decision not to reorder the functions? It makes a huge difference when looking at the files with ediff. I agree that your new ordering makes more sense, but it makes it much harder to look only for the things that actually changed (most of the functions move have not changed at all...). Thanks --dan