From: Dan Nicolaescu <dann@ics.uci.edu>
To: esr@thyrsus.com
Cc: emacs-devel@gnu.org
Subject: Re: new VC, current with changes up to 1.456
Date: Wed, 03 Oct 2007 18:10:28 -0700 [thread overview]
Message-ID: <200710040110.l941ASto012574@oogie-boogie.ics.uci.edu> (raw)
In-Reply-To: <20071003192456.GA8963@thyrsus.com> (Eric S. Raymond's message of "Wed\, 3 Oct 2007 15\:24\:56 -0400")
"Eric S. Raymond" <esr@thyrsus.com> writes:
> Also incorporates review suggestions by Dan Nicolaescu.
I looked at this new version just for a few things that I know that
have changed in vc.el in CVS trunk, they are missing here.
Here's a list:
For the comment at the beginning of vc.el:
- copyright: 2007 missing
- $Id$ has appeared
- please don't say "new version", it won't be "new" soon enough.
- It should be ";; * create-repo ()", not ";; * create-repo (backend)"
- ";; - log-view-mode ()" is missing
- ";; - revision-completion-table (file)" is missing
- diff-tree has disappeared, should it be deleted from all the
backends?
For the rest:
- vc-print-log should call the log-view-mode backend method
- vc-default-log-view-mode is missing
- vc-annotate-display-select should use vc-select-after
- vc-default-revision-completion-table is missing
- vc-default-diff-tree mentions vc-version-diff which does not exist
anymore
- vc-version-other-window should vc-call revision-completion-table
- vc-history-diff should vc-call revision-completion-table
Given that so many things are missing from the merge, can you please
reconsider your decision not to reorder the functions? It makes a huge
difference when looking at the files with ediff. I agree that your new
ordering makes more sense, but it makes it much harder to look only
for the things that actually changed (most of the functions move have
not changed at all...).
Thanks
--dan
next prev parent reply other threads:[~2007-10-04 1:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-03 19:24 new VC, current with changes up to 1.456 Eric S. Raymond
2007-10-04 1:10 ` Dan Nicolaescu [this message]
2007-10-04 2:16 ` Eric S. Raymond
2007-10-04 2:23 ` Dan Nicolaescu
2007-10-04 17:27 ` Richard Stallman
2007-10-04 18:57 ` Dan Nicolaescu
2007-10-04 19:43 ` Eric S. Raymond
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200710040110.l941ASto012574@oogie-boogie.ics.uci.edu \
--to=dann@ics.uci.edu \
--cc=emacs-devel@gnu.org \
--cc=esr@thyrsus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.