From: Dan Nicolaescu <dann@ics.uci.edu>
To: esr@thyrsus.com
Cc: emacs-devel@gnu.org
Subject: Re: New VC mode -- review request
Date: Wed, 03 Oct 2007 17:42:01 -0700 [thread overview]
Message-ID: <200710040042.l940g1B6012034@oogie-boogie.ics.uci.edu> (raw)
In-Reply-To: <20071003170048.GB7014@thyrsus.com> (Eric S. Raymond's message of "Wed\, 3 Oct 2007 13\:00\:48 -0400")
"Eric S. Raymond" <esr@thyrsus.com> writes:
> Dan Nicolaescu <dann@ics.uci.edu>:
> > > Here are the user-visible changes you should expect relative to what's
> > > in the manual:
> > >
> > > * The following commands now operate on filesets rather than files.
> > >
> > > vc-next-action = C-x v v
> > > vc-diff = C-x v =
> > > vc-print-log = C-x v l
> > > vc-revert = C-x v u
> >
> > This does not seem to work for me from vc-dired. I have 2 changed
> > files in a Mercurial. After marking both of them in vc-dired and
> > pressing
> > v u
> > I get this error "Please kill or save all modified buffers before
> > reverting".
> > None of the files is in an emacs buffer.
>
> Hm. I wonder if this is a problem with the hg back end -- I haven't
> tested that. Can you duplicate this behavior with any other back end?
> I'll stare at the code around that error message for a bit when I do
> the merge with top of trunk.
The same thing happens with RCS.
> > > vc-rollback = C-x v c
> >
> > Do you have an implementation for this function for any backend? It
> > would be interesting to see it.
>
> There is one for SCCS in old VC if you want to look at it. I think I
> at one point implemented it for one other backend, but the code and
> concept were so dodgy that I decided it was best shot through the
> head.
>
> Sorry, I don't remember which other back end I implemented it for. I
> do know that most VCSes cannot support this operation at all, it's
> really an SCCSism that got baked into old VC's design by historical
> accident.
OK, thanks, I was trying to see if it would be interesting to try to
support such on operation on modern VCSes...
> > This code in vc-dired-hook:
> >
> > ;; ordinary file
> > ((and (vc-backend filename)
> > (not (and vc-dired-terse-mode
> > (vc-up-to-date-p filename))))
> > (vc-dired-reformat-line (vc-call dired-state-info filename))
> > (forward-line 1))
> >
> > Is the vc-backend call necessary? It ends up calling vc-registered and
> > that can be expensive for the backends that run a program to determine
> > the registered state. The -dir-state method computes the state for
> > most (all?) files...
> > I don't understand this code very well, but if it can be simplified,
> > it might result in a significant speedup for vc-dired.
>
> You're right, it might. I'm not going to change this immediately, it will take
> a little thought and testing, but it's going on my to-do list.
Note to other reviewers: the code above is not new, so doing this
should not affect getting the fileset changes in.
next prev parent reply other threads:[~2007-10-04 0:42 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-03 10:35 New VC mode -- review request Eric S. Raymond
2007-10-03 14:31 ` Dan Nicolaescu
2007-10-03 17:00 ` Eric S. Raymond
2007-10-04 0:42 ` Dan Nicolaescu [this message]
2007-10-04 2:02 ` Eric S. Raymond
2007-10-04 2:14 ` Dan Nicolaescu
2007-10-09 14:55 ` Eric S. Raymond
2007-10-09 15:33 ` Dan Nicolaescu
2007-10-09 17:21 ` Eric S. Raymond
2007-10-04 7:18 ` Thien-Thi Nguyen
2007-10-03 21:32 ` Alexandru Harsanyi
2007-10-04 2:24 ` Dan Nicolaescu
2007-10-04 9:46 ` Alexandru Harsanyi
2007-10-04 9:51 ` Eli Zaretskii
2007-10-04 17:27 ` Richard Stallman
2007-10-04 20:32 ` David Kastrup
2007-10-04 2:02 ` Richard Stallman
2007-10-04 2:22 ` Eric S. Raymond
2007-10-05 16:12 ` Richard Stallman
-- strict thread matches above, loose matches on Subject: below --
2007-10-05 12:15 Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200710040042.l940g1B6012034@oogie-boogie.ics.uci.edu \
--to=dann@ics.uci.edu \
--cc=emacs-devel@gnu.org \
--cc=esr@thyrsus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.