From: Johannes Weiner <hannes@saeurebad.de>
To: Stefan Monnier <monnier@iro.umontreal.ca>,
Richard Stallman <rms@gnu.org>,
emacs-devel@gnu.org
Subject: Re: Please install and ack
Date: Wed, 12 Sep 2007 22:08:48 +0200 [thread overview]
Message-ID: <20070912200848.GB5419@saeurebad.de> (raw)
In-Reply-To: <20070912200237.GA5419@saeurebad.de>
[-- Attachment #1.1.1: Type: text/plain, Size: 27 bytes --]
Hi,
sorry, typo.
Hannes
[-- Attachment #1.1.2: emacs-centralize-abs-r2.patch --]
[-- Type: text/x-diff, Size: 2265 bytes --]
diff -Naur emacs.orig/src/keyboard.c emacs/src/keyboard.c
--- emacs.orig/src/keyboard.c 2007-09-12 22:00:06.000000000 +0200
+++ emacs/src/keyboard.c 2007-09-12 21:53:35.000000000 +0200
@@ -108,8 +108,6 @@
#define KBD_BUFFER_SIZE 4096
#endif /* No X-windows */
-#define abs(x) ((x) >= 0 ? (x) : -(x))
-
/* Following definition copied from eval.c */
struct backtrace
diff -Naur emacs.orig/src/lisp.h emacs/src/lisp.h
--- emacs.orig/src/lisp.h 2007-09-12 22:00:06.000000000 +0200
+++ emacs/src/lisp.h 2007-09-12 22:05:58.000000000 +0200
@@ -3389,6 +3389,12 @@
#define min(a, b) ((a) < (b) ? (a) : (b))
#define max(a, b) ((a) > (b) ? (a) : (b))
+/* Make sure we have abs defined */
+
+#if !defined(abs)
+#define abs(x) ((x) < 0 ? -(x) : (x))
+#endif
+
/* Return a fixnum or float, depending on whether VAL fits in a Lisp
fixnum. */
diff -Naur emacs.orig/src/sound.c emacs/src/sound.c
--- emacs.orig/src/sound.c 2007-09-12 22:00:06.000000000 +0200
+++ emacs/src/sound.c 2007-09-12 21:53:47.000000000 +0200
@@ -96,9 +96,6 @@
#endif /* WINDOWSNT */
-/* BEGIN: Common Definitions */
-#define abs(X) ((X) < 0 ? -(X) : (X))
-
/* Symbols. */
extern Lisp_Object QCfile, QCdata;
diff -Naur emacs.orig/src/w32term.c emacs/src/w32term.c
--- emacs.orig/src/w32term.c 2007-09-12 22:00:06.000000000 +0200
+++ emacs/src/w32term.c 2007-09-12 21:54:03.000000000 +0200
@@ -58,8 +58,6 @@
#include "composite.h"
#include "coding.h"
-#define abs(x) ((x) < 0 ? -(x) : (x))
-
\f
/* Fringe bitmaps. */
diff -Naur emacs.orig/src/xfaces.c emacs/src/xfaces.c
--- emacs.orig/src/xfaces.c 2007-09-12 22:00:06.000000000 +0200
+++ emacs/src/xfaces.c 2007-09-12 21:54:14.000000000 +0200
@@ -267,8 +267,6 @@
#include <ctype.h>
-#define abs(X) ((X) < 0 ? -(X) : (X))
-
/* Number of pt per inch (from the TeXbook). */
#define PT_PER_INCH 72.27
diff -Naur emacs.orig/src/xterm.c emacs/src/xterm.c
--- emacs.orig/src/xterm.c 2007-09-12 22:00:06.000000000 +0200
+++ emacs/src/xterm.c 2007-09-12 21:54:22.000000000 +0200
@@ -154,8 +154,6 @@
#endif
#endif
-#define abs(x) ((x) < 0 ? -(x) : (x))
-
/* Default to using XIM if available. */
#ifdef USE_XIM
int use_xim = 1;
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]
[-- Attachment #2: Type: text/plain, Size: 142 bytes --]
_______________________________________________
Emacs-devel mailing list
Emacs-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-devel
next prev parent reply other threads:[~2007-09-12 20:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-11 20:31 Please install and ack Richard Stallman
2007-09-12 10:08 ` Johannes Weiner
2007-09-12 14:05 ` Stefan Monnier
2007-09-12 20:02 ` Johannes Weiner
2007-09-12 20:08 ` Johannes Weiner [this message]
2007-09-12 18:52 ` Richard Stallman
2007-10-03 13:35 ` Jason Rumney
2007-09-16 8:56 ` Jan Djärv
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070912200848.GB5419@saeurebad.de \
--to=hannes@saeurebad.de \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
--cc=rms@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.