From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Johannes Weiner Newsgroups: gmane.emacs.devel Subject: Re: Your last change to browse-url is bogus. Date: Wed, 12 Sep 2007 12:49:02 +0200 Message-ID: <20070912104902.GA3696@saeurebad.de> References: <87zlzs2qm1.fsf@cadilhac.name> <20070912102039.GD12104@saeurebad.de> <87ejh42mo4.fsf@cadilhac.name> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0146393246==" X-Trace: sea.gmane.org 1189594155 8940 80.91.229.12 (12 Sep 2007 10:49:15 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Wed, 12 Sep 2007 10:49:15 +0000 (UTC) Cc: emacs-devel@gnu.org To: =?iso-8859-1?Q?Micha=EBl?= Cadilhac Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Sep 12 12:49:13 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1IVPmR-0005jy-Ve for ged-emacs-devel@m.gmane.org; Wed, 12 Sep 2007 12:49:12 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IVPmR-0008D2-TW for ged-emacs-devel@m.gmane.org; Wed, 12 Sep 2007 06:49:11 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1IVPmO-0008CX-2N for emacs-devel@gnu.org; Wed, 12 Sep 2007 06:49:08 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1IVPmM-0008B7-KK for emacs-devel@gnu.org; Wed, 12 Sep 2007 06:49:07 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IVPmM-0008Ar-DE for emacs-devel@gnu.org; Wed, 12 Sep 2007 06:49:06 -0400 Original-Received: from saeurebad.de ([85.214.36.134]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1IVPmL-00042M-QL for emacs-devel@gnu.org; Wed, 12 Sep 2007 06:49:06 -0400 Original-Received: by saeurebad.de (Postfix, from userid 1000) id 1B8612F0156; Wed, 12 Sep 2007 12:49:02 +0200 (CEST) Mail-Followup-To: =?iso-8859-1?Q?Micha=EBl?= Cadilhac , emacs-devel@gnu.org In-Reply-To: <87ejh42mo4.fsf@cadilhac.name> User-Agent: Mutt/1.5.16 (2007-06-11) X-Detected-Kernel: Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:78659 Archived-At: --===============0146393246== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="5mCyUwZo2JvN/JJP" Content-Disposition: inline --5mCyUwZo2JvN/JJP Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Micha, On Wed, Sep 12, 2007 at 12:38:51PM +0200, Micha=EBl Cadilhac wrote: > >> --- browse-url.el 12 Sep 2007 10:49:04 +0200 1.61 > >> +++ browse-url.el 12 Sep 2007 11:09:27 +0200=09 > > [...] > >> - (setq file (browse-url-encode-url file)) > >> + (setq file (browse-url-encode-url file "[*\"()',=3D;? ]" 'encode-pe= rcent)) > > [...] > >> - (setq url (browse-url-encode-url url)) > >> + (setq url (browse-url-encode-url url "[,)$]")) > > [...] > >> - (setq url (browse-url-encode-url url)) > >> + (setq url (browse-url-encode-url url "[,)$]")) > > [...] > >> - (setq url (browse-url-encode-url url)) > >> + (setq url (browse-url-encode-url url "[,)$]")) > > [...] > >> - (setq url (browse-url-encode-url url)) > >> + (setq url (browse-url-encode-url url "[,)$]")) > > [...] > >> - (setq url (browse-url-encode-url url)) > >> + (setq url (browse-url-encode-url url "[,)$]")) > > [...] > >> - (setq url (browse-url-encode-url url)) > >> + (setq url (browse-url-encode-url url "[,)$]")) > > > > These use mostly the same argument. Can't we generalize this? Would i= t hurt > > the callsites if they all would use "[*\"()',=3D;? ]"? >=20 > Yes, it will. A ``confusing char'' is just something Firefox or others > can consider as a URL separator or as a variable or something when the > website is passed as an argument to the executable, AFAIU. >=20 > `?=3D*' for example are not usually ``confusing''. The only place those > chars are to be converted is when we browse for a file (thus when `?=3D' > don't have their special meanings). Ah, okay. So what about an (&optional filename) for this function? And if it's true, the character set to be translated is "[*\"()',=3D;? ]" a= nd percent is also encoded. If ommited (nil), just "[,)$]" will be translated. How does that sound? Hannes --5mCyUwZo2JvN/JJP Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (GNU/Linux) iD8DBQFG58QedvEGNHGk3KARAsYGAKCBDNx9BoKSe67GeqKxUcIACxI8oACeLRv1 dCVkS+sWLdQqjEY3YrKX7QM= =lDf0 -----END PGP SIGNATURE----- --5mCyUwZo2JvN/JJP-- --===============0146393246== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Emacs-devel mailing list Emacs-devel@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-devel --===============0146393246==--