From: Johannes Weiner <hannes@saeurebad.de>
To: "Michaël Cadilhac" <michael@cadilhac.name>
Cc: emacs-devel@gnu.org
Subject: Re: Your last change to browse-url is bogus.
Date: Wed, 12 Sep 2007 12:20:39 +0200 [thread overview]
Message-ID: <20070912102039.GD12104@saeurebad.de> (raw)
In-Reply-To: <87zlzs2qm1.fsf@cadilhac.name>
[-- Attachment #1.1: Type: text/plain, Size: 1273 bytes --]
Hi Micha,
On Wed, Sep 12, 2007 at 11:13:42AM +0200, Michaël Cadilhac wrote:
> I'd suggest to revert this change or, if it's for the sake of code
> factoring, (what was the first purpose, by the way?)
Yes, code factoring.
> use something like this:
> --- browse-url.el 12 Sep 2007 10:49:04 +0200 1.61
> +++ browse-url.el 12 Sep 2007 11:09:27 +0200
[...]
> - (setq file (browse-url-encode-url file))
> + (setq file (browse-url-encode-url file "[*\"()',=;? ]" 'encode-percent))
[...]
> - (setq url (browse-url-encode-url url))
> + (setq url (browse-url-encode-url url "[,)$]"))
[...]
> - (setq url (browse-url-encode-url url))
> + (setq url (browse-url-encode-url url "[,)$]"))
[...]
> - (setq url (browse-url-encode-url url))
> + (setq url (browse-url-encode-url url "[,)$]"))
[...]
> - (setq url (browse-url-encode-url url))
> + (setq url (browse-url-encode-url url "[,)$]"))
[...]
> - (setq url (browse-url-encode-url url))
> + (setq url (browse-url-encode-url url "[,)$]"))
[...]
> - (setq url (browse-url-encode-url url))
> + (setq url (browse-url-encode-url url "[,)$]"))
These use mostly the same argument. Can't we generalize this? Would it hurt
the callsites if they all would use "[*\"()',=;? ]"?
Hannes
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]
[-- Attachment #2: Type: text/plain, Size: 142 bytes --]
_______________________________________________
Emacs-devel mailing list
Emacs-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-devel
next prev parent reply other threads:[~2007-09-12 10:20 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-12 9:13 Your last change to browse-url is bogus Michaël Cadilhac
2007-09-12 10:20 ` Johannes Weiner [this message]
2007-09-12 10:38 ` Michaël Cadilhac
2007-09-12 10:49 ` Johannes Weiner
2007-09-12 11:09 ` Michaël Cadilhac
2007-09-12 11:25 ` Johannes Weiner
2007-09-12 11:46 ` Michaël Cadilhac
2007-09-12 12:54 ` YAMAMOTO Mitsuharu
2007-09-12 13:13 ` Michaël Cadilhac
2007-09-12 14:18 ` YAMAMOTO Mitsuharu
2007-09-12 22:50 ` Michaël Cadilhac
2007-09-17 4:40 ` YAMAMOTO Mitsuharu
2007-09-17 11:52 ` Michaël Cadilhac
2007-09-12 23:29 ` Stephen J. Turnbull
2007-09-13 2:30 ` Stefan Monnier
2007-09-13 18:15 ` Stephen J. Turnbull
2007-09-13 21:44 ` Stefan Monnier
2007-09-13 2:39 ` Davis Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070912102039.GD12104@saeurebad.de \
--to=hannes@saeurebad.de \
--cc=emacs-devel@gnu.org \
--cc=michael@cadilhac.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.