From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "d.henman" Newsgroups: gmane.emacs.devel Subject: Re: Failure in building Emacs 23.0.50 on Cygwin (fwd) Date: Sat, 08 Sep 2007 16:21:21 +0900 Message-ID: <20070908162121.1704@blackhawk> References: <20070903075037.2652@blackhawk> <20070903092334.2296@blackhawk> <200709041620.l84GKRKJ026897@oogie-boogie.ics.uci.edu> <200709042136.l84Lawms007683@oogie-boogie.ics.uci.edu> <200709051738.l85HcYIp008041@oogie-boogie.ics.uci.edu> <200709052022.l85KMftF014117@oogie-boogie.ics.uci.edu> <200709052054.l85KsfQf015447@oogie-boogie.ics.uci.edu> <200709061626.l86GQW6H018052@oogie-boogie.ics.uci.edu> <20070907082641.2052@blackhawk> NNTP-Posting-Host: lo.gmane.org X-Trace: sea.gmane.org 1189236104 1987 80.91.229.12 (8 Sep 2007 07:21:44 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sat, 8 Sep 2007 07:21:44 +0000 (UTC) Cc: Eli Zaretskii , Dan Nicolaescu , emacs-devel@gnu.org, Angelo Graziosi To: "d. henman" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Sep 08 09:21:44 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1ITudP-0007Ab-Ss for ged-emacs-devel@m.gmane.org; Sat, 08 Sep 2007 09:21:40 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1ITudN-0003ns-AR for ged-emacs-devel@m.gmane.org; Sat, 08 Sep 2007 03:21:37 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1ITudI-0003jU-WF for emacs-devel@gnu.org; Sat, 08 Sep 2007 03:21:33 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1ITudH-0003gB-Bt for emacs-devel@gnu.org; Sat, 08 Sep 2007 03:21:32 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1ITudH-0003g1-8s for emacs-devel@gnu.org; Sat, 08 Sep 2007 03:21:31 -0400 Original-Received: from mx20.gnu.org ([199.232.41.8]) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1ITudD-00008h-02; Sat, 08 Sep 2007 03:21:27 -0400 Original-Received: from mail1.asahi-net.or.jp ([202.224.39.197] helo=mail.asahi-net.or.jp) by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1ITudC-0005PL-6j; Sat, 08 Sep 2007 03:21:26 -0400 Original-Received: from blackhawk (x065158.ppp.asahi-net.or.jp [122.249.65.158]) by mail.asahi-net.or.jp (Postfix) with ESMTP id B5CDE6660; Sat, 8 Sep 2007 16:21:11 +0900 (JST) In-reply-to: Your message of Fri, 07 Sep 2007 08:26:41 +0900 <20070907082641.2052@blackhawk> X-Mailer: MH-E 8.0.3; GNU Mailutils 1.2.1; GNU Emacs 22.1.50 X-detected-kernel: Genre and OS details not recognized. X-Detected-Kernel: Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:78222 Archived-At: Having said that, the original supplied patch was more symmetrical, in the context it was given and easier to maintain and provided for a closure reference. So now we have #elif mixed with #else #ifdefs with #endif for the legacy items.... You might has well have made the whole code segment modern using #elifs... Are there any conventions regarding this? Regards, darel henman d.henman wrote: > > Thanks from all of us unfortunate ones who have to use cygwin. > > In case you can't find the patch I will inline it below. My papers are in, so there is no legal problem. > > Regards, > Darel Henman > > Dan Nicolaescu wrote: > > > Angelo Graziosi writes: > > > > > On Wed, 5 Sep 2007, Dan Nicolaescu wrote: > > > > > > > Angelo Graziosi writes: > > > > > > > > > As I said in the last replay, I can suspend/resume both (emacs, > > > > > emacsclient). > > > > > > > > > > After resume, I can continue to edit files typing in the terminal. > > > > > > > > > > All these things with a build of Emacs checked out about 12 hours ago, > > > > > having applied the 'famous' patch... > > > > > > > > Thanks! Then, IMO, the patch should go in. > > > > > > > > > > > > > > Who should submit it ? If you can and if the patch is valid, may you ? > > > > I will do it later today in case nobody beat me to it. > --- term.c 2007-08-30 06:46:50.000000000 +0900 > +++ /tmp/term.c.fixed 2007-09-03 09:15:22.915209300 +0900 > @@ -3131,6 +3131,10 @@ > setpgrp (); > no_controlling_tty = 1; > #else > +#ifdef CYGWIN > + setsid (); > + no_controlling_tty = 1; > +#else > #ifdef TIOCNOTTY /* Try BSD ioctls. */ > sigblock (sigmask (SIGTTOU)); > fd = emacs_open ("/dev/tty", O_RDWR, 0); > @@ -3145,6 +3149,7 @@ > /* Unknown system. */ > croak (); > #endif /* ! TIOCNOTTY */ > +#endif /* ! CYGWIN */ > #endif /* ! USG */ > } > #endif