Re: Failure in building Emacs 23.0.50 on Cygwin (fwd)

["d.henman" <dhenman@gmail.com>]

Having said that, the original supplied patch was more symmetrical, in the context it was given and easier to maintain and provided for a closure reference. 

So now we have #elif mixed with #else #ifdefs with #endif for the legacy items....

You might has well have made the whole code segment modern using #elifs...

Are there any conventions regarding this?

Regards,
  darel henman

d.henman <dhenman@gmail.com> wrote:

> 
> Thanks from all of us unfortunate ones who have to use cygwin.
> 
> In case you can't find the patch I will inline it below.  My papers are in, so there is no legal problem.
> 
> Regards,
>    Darel Henman
> 
> Dan Nicolaescu <dann@ics.uci.edu> wrote:
> 
> > Angelo Graziosi <Angelo.Graziosi@roma1.infn.it> writes:
> > 
> >   > On Wed, 5 Sep 2007, Dan Nicolaescu wrote:
> >   > 
> >   > > Angelo Graziosi <Angelo.Graziosi@roma1.infn.it> writes:
> >   > >
> >   > >   > As I said in the last replay, I can suspend/resume both (emacs,
> >   > >   > emacsclient).
> >   > >   >
> >   > >   > After resume, I can continue to edit files typing in the terminal.
> >   > >   >
> >   > >   > All these things with a build of Emacs checked out about 12 hours ago,
> >   > >   > having applied the 'famous' patch...
> >   > >
> >   > > Thanks! Then, IMO, the patch should go in.
> >   > >
> >   > >
> >   > 
> >   > Who should submit it ? If you can and if the patch is valid, may you ?
> > 
> > I will do it later today in case nobody beat me to it.
> --- term.c	2007-08-30 06:46:50.000000000 +0900
> +++ /tmp/term.c.fixed	2007-09-03 09:15:22.915209300 +0900
> @@ -3131,6 +3131,10 @@
>        setpgrp ();
>        no_controlling_tty = 1;
>  #else
> +#ifdef CYGWIN
> +      setsid ();
> +      no_controlling_tty = 1;
> +#else
>  #ifdef TIOCNOTTY                /* Try BSD ioctls. */
>        sigblock (sigmask (SIGTTOU));
>        fd = emacs_open ("/dev/tty", O_RDWR, 0);
> @@ -3145,6 +3149,7 @@
>        /* Unknown system. */
>        croak ();
>  #endif  /* ! TIOCNOTTY */
> +#endif  /* ! CYGWIN */
>  #endif  /* ! USG */
>      }
>  #endif