From: Dan Nicolaescu <dann@ics.uci.edu>
To: Angelo Graziosi <Angelo.Graziosi@roma1.infn.it>
Cc: Eli Zaretskii <eliz@gnu.org>, "d.henman" <dhenman@gmail.com>,
emacs-devel@gnu.org
Subject: Re: Failure in building Emacs 23.0.50 on Cygwin (fwd)
Date: Tue, 04 Sep 2007 14:36:58 -0700 [thread overview]
Message-ID: <200709042136.l84Lawms007683@oogie-boogie.ics.uci.edu> (raw)
In-Reply-To: <Pine.OSF.4.58.0709042248070.25754@ax0rm1.roma1.infn.it> (Angelo Graziosi's message of "Tue\, 4 Sep 2007 22\:53\:47 +0200 \(MET DST\)")
Angelo Graziosi <Angelo.Graziosi@roma1.infn.it> writes:
> On Tue, 4 Sep 2007, Dan Nicolaescu wrote:
>
> > "d.henman" <dhenman@gmail.com> writes:
> >
> > > Angelo,
> > >
> > > content wise it looks good to me, but I think that changing it to the following
> > > format, same content as your patch (see modifed patch below ), but this format makes it easier to understand and would give it more robustness for future mainenance and any possible changes and extensions for CYGWIN specific issues.
> > >
> > > Also I would like to wait and get a response from the cygwin developers, before any commit is made.
> > >
> > > Regards,
> > > Darel Henman
> > >
> > > ----------------------------------------------------------------
> > > --- term.c 2007-08-30 06:46:50.000000000 +0900
> > > +++ /tmp/term.c.fixed 2007-09-03 09:15:22.915209300 +0900
> > > @@ -3131,6 +3131,10 @@
> > > setpgrp ();
> > > no_controlling_tty = 1;
> > > #else
> > > +#ifdef CYGWIN
> > > + setsid ();
> > > + no_controlling_tty = 1;
> > > +#else
> > > #ifdef TIOCNOTTY /* Try BSD ioctls. */
> > > sigblock (sigmask (SIGTTOU));
> > > fd = emacs_open ("/dev/tty", O_RDWR, 0);
> > > @@ -3145,6 +3149,7 @@
> > > /* Unknown system. */
> > > croak ();
> > > #endif /* ! TIOCNOTTY */
> > > +#endif /* ! CYGWIN */
> > > #endif /* ! USG */
> > > }
> > > #endif
> >
> >
> > Just my curiosity, does this patch make emacs work on cygwin?
> > If it doesn't, is this function called before things go bad?
>
>
> IF 'setpgrp' is similar to 'setsid'
> (http://www.opengroup.org/onlinepubs/009695399/functions/setsid.html) AND
> IF Cygwin list suggests to use 'setsid' to dissociate TTY
> (http://cygwin.com/ml/cygwin/2007-09/msg00026.html) THEN
>
> the above patch is quite natural... OR NOT?
You have not answered the fundamental question: does the patch work?
I don't think this code path is exercised if you run in a window
system, it will probably only be used if you use "emacsclient -t" or
"emacs -nw".
next prev parent reply other threads:[~2007-09-04 21:36 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-02 22:10 Failure in building Emacs 23.0.50 on Cygwin (fwd) Angelo Graziosi
2007-09-02 22:50 ` d.henman
2007-09-02 23:40 ` Angelo Graziosi
2007-09-03 0:23 ` d.henman
2007-09-04 16:20 ` Dan Nicolaescu
2007-09-04 20:41 ` Angelo Graziosi
2007-09-04 20:53 ` Angelo Graziosi
2007-09-04 21:36 ` Dan Nicolaescu [this message]
2007-09-05 8:53 ` Angelo Graziosi
2007-09-05 17:38 ` Dan Nicolaescu
2007-09-05 19:58 ` Angelo Graziosi
2007-09-05 20:22 ` Dan Nicolaescu
2007-09-05 20:40 ` Angelo Graziosi
2007-09-05 20:54 ` Dan Nicolaescu
2007-09-06 10:09 ` Angelo Graziosi
2007-09-06 16:26 ` Dan Nicolaescu
2007-09-06 23:26 ` d.henman
2007-09-07 4:06 ` Jashy
2007-09-08 7:05 ` d.henman
[not found] ` <E1IUCJM-0000k5-N0@fencepost.gnu.org>
2007-09-09 8:17 ` David Kastrup
2007-09-09 20:06 ` Richard Stallman
2007-09-09 21:31 ` Angelo Graziosi
2007-09-10 16:52 ` Richard Stallman
2007-09-09 22:27 ` d.henman
2007-09-10 1:13 ` Richard Stallman
2007-09-08 7:21 ` d.henman
2007-09-07 3:58 ` Dan Nicolaescu
2007-09-07 8:04 ` NEW failure in building Emacs 23.0.50 on Cygwin Angelo Graziosi
2007-09-07 20:05 ` Stefan Monnier
2007-09-07 23:38 ` Angelo Graziosi
2007-09-05 9:32 ` Failure in building Emacs 23.0.50 on Cygwin (fwd) Andreas Schwab
2007-09-05 9:44 ` d.henman
-- strict thread matches above, loose matches on Subject: below --
2007-09-05 20:11 Angelo Graziosi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200709042136.l84Lawms007683@oogie-boogie.ics.uci.edu \
--to=dann@ics.uci.edu \
--cc=Angelo.Graziosi@roma1.infn.it \
--cc=dhenman@gmail.com \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.