From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dan Nicolaescu Newsgroups: gmane.emacs.devel Subject: Re: Failure in building Emacs 23.0.50 on Cygwin (fwd) Date: Tue, 04 Sep 2007 09:20:27 -0700 Message-ID: <200709041620.l84GKRKJ026897@oogie-boogie.ics.uci.edu> References: <20070903075037.2652@blackhawk> <20070903092334.2296@blackhawk> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1188922969 22813 80.91.229.12 (4 Sep 2007 16:22:49 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Tue, 4 Sep 2007 16:22:49 +0000 (UTC) Cc: Eli Zaretskii , Angelo Graziosi , emacs-devel@gnu.org To: "d.henman" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Sep 04 18:22:49 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1ISbAq-0000s2-Cj for ged-emacs-devel@m.gmane.org; Tue, 04 Sep 2007 18:22:44 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1ISbAo-0002ox-PD for ged-emacs-devel@m.gmane.org; Tue, 04 Sep 2007 12:22:42 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1ISbAk-0002mT-IJ for emacs-devel@gnu.org; Tue, 04 Sep 2007 12:22:38 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1ISbAi-0002k1-LE for emacs-devel@gnu.org; Tue, 04 Sep 2007 12:22:38 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1ISbAi-0002jr-IK for emacs-devel@gnu.org; Tue, 04 Sep 2007 12:22:36 -0400 Original-Received: from oogie-boogie.ics.uci.edu ([128.195.1.41]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1ISbAd-000213-FT; Tue, 04 Sep 2007 12:22:32 -0400 Original-Received: from mothra.ics.uci.edu (mothra.ics.uci.edu [128.195.6.93]) by oogie-boogie.ics.uci.edu (8.13.6/8.13.6) with ESMTP id l84GKRKJ026897; Tue, 4 Sep 2007 09:20:27 -0700 (PDT) In-Reply-To: <20070903092334.2296@blackhawk> (d. henman's message of "Mon\, 03 Sep 2007 09\:23\:34 +0900") Original-Lines: 42 X-ICS-MailScanner: Found to be clean X-ICS-MailScanner-SpamCheck: not spam, SpamAssassin (score=-1.44, required 5, autolearn=disabled, ALL_TRUSTED -1.44) X-ICS-MailScanner-From: dann@mothra.ics.uci.edu X-Detected-Kernel: Solaris 9 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:77746 Archived-At: "d.henman" writes: > Angelo, > > content wise it looks good to me, but I think that changing it to the following > format, same content as your patch (see modifed patch below ), but this format makes it easier to understand and would give it more robustness for future mainenance and any possible changes and extensions for CYGWIN specific issues. > > Also I would like to wait and get a response from the cygwin developers, before any commit is made. > > Regards, > Darel Henman > > ---------------------------------------------------------------- > --- term.c 2007-08-30 06:46:50.000000000 +0900 > +++ /tmp/term.c.fixed 2007-09-03 09:15:22.915209300 +0900 > @@ -3131,6 +3131,10 @@ > setpgrp (); > no_controlling_tty = 1; > #else > +#ifdef CYGWIN > + setsid (); > + no_controlling_tty = 1; > +#else > #ifdef TIOCNOTTY /* Try BSD ioctls. */ > sigblock (sigmask (SIGTTOU)); > fd = emacs_open ("/dev/tty", O_RDWR, 0); > @@ -3145,6 +3149,7 @@ > /* Unknown system. */ > croak (); > #endif /* ! TIOCNOTTY */ > +#endif /* ! CYGWIN */ > #endif /* ! USG */ > } > #endif Just my curiosity, does this patch make emacs work on cygwin? If it doesn't, is this function called before things go bad? If you configure with X11 support, does the X11 version work? Theoretically it should work by default, but if it does not, fixing it might help find things that would help the -nw case...