From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "d.henman" Newsgroups: gmane.emacs.devel Subject: Re: Failure in building Emacs 23.0.50 on Cygwin (fwd) Date: Mon, 03 Sep 2007 09:23:34 +0900 Message-ID: <20070903092334.2296@blackhawk> References: <20070903075037.2652@blackhawk> NNTP-Posting-Host: lo.gmane.org X-Trace: sea.gmane.org 1188779035 8287 80.91.229.12 (3 Sep 2007 00:23:55 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Mon, 3 Sep 2007 00:23:55 +0000 (UTC) Cc: Eli Zaretskii , Dan Nicolaescu , "d. henman" , emacs-devel@gnu.org To: "Angelo Graziosi" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Sep 03 02:23:54 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1IRzjK-0003Iw-4j for ged-emacs-devel@m.gmane.org; Mon, 03 Sep 2007 02:23:50 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IRzjI-0002Ap-LE for ged-emacs-devel@m.gmane.org; Sun, 02 Sep 2007 20:23:48 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1IRzjD-00028Y-PZ for emacs-devel@gnu.org; Sun, 02 Sep 2007 20:23:43 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1IRzjB-00025E-M4 for emacs-devel@gnu.org; Sun, 02 Sep 2007 20:23:42 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IRzjB-000251-In for emacs-devel@gnu.org; Sun, 02 Sep 2007 20:23:41 -0400 Original-Received: from mail1.asahi-net.or.jp ([202.224.39.197] helo=mail.asahi-net.or.jp) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1IRzj7-0002Zc-3o; Sun, 02 Sep 2007 20:23:37 -0400 Original-Received: from blackhawk (p044069.ppp.asahi-net.or.jp [221.113.44.69]) by mail.asahi-net.or.jp (Postfix) with ESMTP id 3C5A066CD; Mon, 3 Sep 2007 09:23:34 +0900 (JST) In-reply-to: Your message of Mon, 3 Sep 2007 01:40:56 +0200 X-Mailer: MH-E 8.0.3; GNU Mailutils 1.2.1; GNU Emacs 22.1.50 X-Detected-Kernel: Genre and OS details not recognized. X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:77626 Archived-At: Angelo, content wise it looks good to me, but I think that changing it to the following format, same content as your patch (see modifed patch below ), but this format makes it easier to understand and would give it more robustness for future mainenance and any possible changes and extensions for CYGWIN specific issues. Also I would like to wait and get a response from the cygwin developers, before any commit is made. Regards, Darel Henman ---------------------------------------------------------------- --- term.c 2007-08-30 06:46:50.000000000 +0900 +++ /tmp/term.c.fixed 2007-09-03 09:15:22.915209300 +0900 @@ -3131,6 +3131,10 @@ setpgrp (); no_controlling_tty = 1; #else +#ifdef CYGWIN + setsid (); + no_controlling_tty = 1; +#else #ifdef TIOCNOTTY /* Try BSD ioctls. */ sigblock (sigmask (SIGTTOU)); fd = emacs_open ("/dev/tty", O_RDWR, 0); @@ -3145,6 +3149,7 @@ /* Unknown system. */ croak (); #endif /* ! TIOCNOTTY */ +#endif /* ! CYGWIN */ #endif /* ! USG */ } #endif ----------------------------------------------------------------