Re: Failure in building Emacs 23.0.50 on Cygwin

From: "d.henman" <dhenman@gmail.com>
To: "Dan Nicolaescu" <dann@ics.uci.edu>
Cc: emacs-devel@gnu.org
Subject: Re: Failure in building Emacs 23.0.50 on Cygwin
Date: Sat, 01 Sep 2007 12:53:13 +0900	[thread overview]
Message-ID: <20070901125313.1488@blackhawk> (raw)
In-Reply-To: Your message of Fri, 31 Aug 2007 17:35:58 -0700 <200709010035.l810Zwni021513@oogie-boogie.ics.uci.edu>

[-- Attachment #1: Type: text/plain, Size: 377 bytes --]


Dan Nicolaescu <dann@ics.uci.edu> wrote:
> IMO the question should be asked the other way: how do you avoid
> references to "croak". 
> 
> Adjust preprocessor code in dissociate_if_controlling_tty so that
> croak is not used. Whether that is enough to make cygwin work, I don't
> know. 

Here is the patch I came up with to avoid a reference to croak on the
cygwin platform.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: term.c patch for cygwin --]
[-- Type: text/x-c, Size: 337 bytes --]

--- term.c	2007-08-30 06:46:50.000000000 +0900
+++ term.c.fixed	2007-09-01 10:39:51.906250000 +0900
@@ -3142,8 +3142,10 @@
         emacs_close (fd);
       sigunblock (sigmask (SIGTTOU));
 #else
+#ifndef CYGWIN
       /* Unknown system. */
       croak ();
+#endif  /* ! CYGWIN */
 #endif  /* ! TIOCNOTTY */
 #endif  /* ! USG */
     }

[-- Attachment #3: Type: text/plain, Size: 90 bytes --]


Please review this and let me know if I can check it into cvs.

Regards,
  Darel Henman


[-- Attachment #4: Type: text/plain, Size: 142 bytes --]

_______________________________________________
Emacs-devel mailing list
Emacs-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-devel
