* vc-svn crash - calling dolist on a string
@ 2007-08-31 13:40 Chris Moore
2007-08-31 14:08 ` Dan Nicolaescu
0 siblings, 1 reply; 2+ messages in thread
From: Chris Moore @ 2007-08-31 13:40 UTC (permalink / raw)
To: emacs-pretest-bug
[-- Attachment #1.1: Type: text/plain, Size: 1327 bytes --]
In GNU Emacs 22.1.50.3 (i686-pc-linux-gnu, GTK+ Version 2.10.11)
of 2007-08-28 on trpaslik
Windowing system distributor `The X.Org Foundation', version 11.0.70200000
configured using `configure '--with-gtk' '--prefix' '/usr/local'
'--with-xpm' '--with-jpeg' '--with-png' '--with-gif''
The recent change to vc-svn.el seems to be a little wrong. vc-svn-diff does
(dolist (f files) ... where files is its first argument. However, that
first argument isn't always a list. See how it's called here:
(defun vc-svn-diff-tree (dir &optional rev1 rev2)
"Diff all files at and below DIR."
(vc-svn-diff (file-name-as-directory dir) rev1 rev2))
I was visiting a svn-controlled source file and typed C-u C-x v = RET 567
RET, hoping to compare version 567 of the current source file with the
version I was looking at, but instead got the above error.
Checking with "C-x ESC ESC", I see that vc-version-diff wasn't called how I
was expecting it to be. I see that what was called to get the error was:
(vc-version-diff "/home/chris/programs/" "567" "")
whereas what I would expect to see is:
(vc-version-diff "/home/chris/programs/file.c" "567" "")
Somehow the first RET I typed, to the "File or dir to diff (default visited
file)" prompt didn't default to the visited file, but instead literally used
the directory itself.
[-- Attachment #1.2: Type: text/html, Size: 1647 bytes --]
[-- Attachment #2: Type: text/plain, Size: 142 bytes --]
_______________________________________________
Emacs-devel mailing list
Emacs-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: vc-svn crash - calling dolist on a string
2007-08-31 13:40 vc-svn crash - calling dolist on a string Chris Moore
@ 2007-08-31 14:08 ` Dan Nicolaescu
0 siblings, 0 replies; 2+ messages in thread
From: Dan Nicolaescu @ 2007-08-31 14:08 UTC (permalink / raw)
To: Chris Moore; +Cc: emacs-pretest-bug
"Chris Moore" <dooglus@gmail.com> writes:
> In GNU Emacs 22.1.50.3 (i686-pc-linux-gnu, GTK+ Version 2.10.11)
> of 2007-08-28 on trpaslik
> Windowing system distributor `The X.Org Foundation', version 11.0.70200000
> configured using `configure '--with-gtk' '--prefix' '/usr/local' '--with-xpm'
> '--with-jpeg' '--with-png' '--with-gif''
>
> The recent change to vc-svn.el seems to be a little wrong. vc-svn-diff does
> (dolist (f files) ... where files is its first argument. However, that first
> argument isn't always a list. See how it's called here:
>
Thanks, I checked in a fix, please test it.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-08-31 14:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-08-31 13:40 vc-svn crash - calling dolist on a string Chris Moore
2007-08-31 14:08 ` Dan Nicolaescu
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.