22.1.50; Suggestion: defalias line-move-invisible-p to text-invisible-p

22.1.50; Suggestion: defalias line-move-invisible-p to text-invisible-p

[raman]

I suggest adding
(defalias 'line-move-invisible-p 'text-invisible-p)
to simple.el --
the latter name better reflects what it does and makes it more discoverable.


In GNU Emacs 22.1.50.23 (i686-pc-linux-gnu, GTK+ Version 2.8.20)
 of 2007-08-21 on labrador
configured using `configure  '--prefix=/usr/local' '--with-toolkit=gtk''

Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: en_US.UTF-8
  locale-coding-system: utf-8
  default-enable-multibyte-characters: nil

Major mode: MSpools

Minor modes in effect:
  erc-track-minor-mode: t
  jabber-activity-mode: t
  dired-omit-mode: t
  dynamic-completion-mode: t
  shell-dirtrack-mode: t
  savehist-mode: t
  display-time-mode: t
  desktop-save-mode: t
  auto-insert-mode: t
  encoded-kbd-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  unify-8859-on-encoding-mode: t
  utf-translate-cjk-mode: t
  auto-compression-mode: t

Recent input:
e r RET C-p C-n ESC > C-q C-c RET ESC > s s h SPC r 
e t r i e v e r RET ESC > C-p C-p C-p ESC > s s h SPC 
r e t r i e v e r SPC RET C-p C-p ESC > s s h SPC - 
v SPC t DEL C-c C-u s s h SPC - - h e l p RET C-r t 
r a c ESC m ESC > C-r v e r b ESC m C-p ESC m ESC [ 
C C-e c ESC > s s h SPC - v SPC r e t r i e v e r RET 
C-p C-n C-p C-p C-p C-p C-n C-e e ESC b ESC b C-e w 
C-p C-p C-p C-p C-p C-p C-p C-p C-p C-p C-c C-p C-n 
C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-e e ESC b 
ESC b ESC b ESC b C-e w ESC b ESC f ESC b ESC b ESC 
f C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n 
C-n C-n C-n ESC > s s h SPC r e t r i e v e r SPC l 
s RET C-p C-p C-n C-n ESC > e x i t RET C-e l C-e x 
m ESC m n n SPC d n j ' n n j ' n n n n j ' ESC c q 
ESC m SPC n j ' n j ' n j ' n j ' ESC c q ESC x e DEL 
r e p o r t - e m ESC TAB C-g C-g ESC x r e p o r t 
SPC e m TAB b TAB RET

Recent messages:
Writing index file...
Wrote /home/raman/Mail/lists/.xemacs.idx
Writing index file... done
/home/raman/Mail/lists/xemacs removed
nil
Loading etags...done
Making tags completion table for /home/raman/emacs/lisp/emacspeak/lisp/TAGS...done
Can't find completion for "report-em"
Quit [2 times]
Loading emacsbug...done

-- 
Best Regards,
--raman

      
Email:  raman@users.sf.net
WWW:    http://emacspeak.sf.net/raman/
AIM:    emacspeak       GTalk: tv.raman.tv@gmail.com
PGP:    http://emacspeak.sf.net/raman/raman-almaden.asc
Google: tv+raman 
IRC:    irc://irc.freenode.net/#emacs

Re: 22.1.50; Suggestion: defalias line-move-invisible-p to text-invisible-p

[Stefan Monnier]

> I suggest adding
> (defalias 'line-move-invisible-p 'text-invisible-p)
> to simple.el --
> the latter name better reflects what it does and makes it more discoverable.

Indeed, I had the same idea, but hadn't committed the patch yet.  Good thing
too because your name makes more sense than the one I had chosen,


        Stefan

Re: 22.1.50; Suggestion: defalias line-move-invisible-p to text-invisible-p

[Richard Stallman]

    I suggest adding
    (defalias 'line-move-invisible-p 'text-invisible-p)
    to simple.el --

We have never documented the name `line-move-invisible-p',
so we could just rename it.

Re: 22.1.50; Suggestion: defalias line-move-invisible-p to text-invisible-p

[Stefan Monnier]

>     I suggest adding
>     (defalias 'line-move-invisible-p 'text-invisible-p)
>     to simple.el --

> We have never documented the name `line-move-invisible-p',
> so we could just rename it.

I kept it as an obsolete alias in 22.2, just to be on the safe side, and am
planning to remove it from the trunk as soon as the change gets synced to
the trunk.


        Stefan

Re: 22.1.50; Suggestion: defalias line-move-invisible-p to text-invisible-p

[Richard Stallman]

I am not sure text-invisible-p is the clearest name.
It suggests something that asks about "text".
This function asks about the character after a certain position.
A different name might be better.