From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dan Nicolaescu Newsgroups: gmane.emacs.devel Subject: Re: VC acting strangely Date: Sat, 04 Aug 2007 08:22:10 -0700 Message-ID: <200708041522.l74FMAaQ011222@oogie-boogie.ics.uci.edu> References: <46B3D9A2.7080708@gnu.org> <200708040227.l742R3uW025802@oogie-boogie.ics.uci.edu> <46B43673.7090008@gnu.org> <85ir7vity2.fsf@lola.goethe.zz> <85ejijisxe.fsf@lola.goethe.zz> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1186241191 21010 80.91.229.12 (4 Aug 2007 15:26:31 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sat, 4 Aug 2007 15:26:31 +0000 (UTC) Cc: Emacs Devel , Jason Rumney To: David Kastrup Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Aug 04 17:26:29 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1IHLWK-0001UT-EI for ged-emacs-devel@m.gmane.org; Sat, 04 Aug 2007 17:26:28 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IHLWI-0003D6-Bf for ged-emacs-devel@m.gmane.org; Sat, 04 Aug 2007 11:26:22 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1IHLWD-0003Ci-Q9 for emacs-devel@gnu.org; Sat, 04 Aug 2007 11:26:17 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1IHLW1-00035X-Tc for emacs-devel@gnu.org; Sat, 04 Aug 2007 11:26:16 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IHLW1-00035C-OS for emacs-devel@gnu.org; Sat, 04 Aug 2007 11:26:05 -0400 Original-Received: from [128.195.1.41] (helo=oogie-boogie.ics.uci.edu) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1IHLVU-0007Kb-7x; Sat, 04 Aug 2007 11:25:35 -0400 Original-Received: from mothra.ics.uci.edu (mothra.ics.uci.edu [128.195.6.93]) by oogie-boogie.ics.uci.edu (8.13.6/8.13.6) with ESMTP id l74FMAaQ011222; Sat, 4 Aug 2007 08:22:10 -0700 (PDT) In-Reply-To: <85ejijisxe.fsf@lola.goethe.zz> (David Kastrup's message of "Sat\, 04 Aug 2007 10\:51\:25 +0200") Original-Lines: 53 X-ICS-MailScanner: Found to be clean X-ICS-MailScanner-SpamCheck: not spam, SpamAssassin (score=-0.24, required 5, autolearn=disabled, ALL_TRUSTED -1.44, J_CHICKENPOX_22 0.60, J_CHICKENPOX_33 0.60) X-ICS-MailScanner-From: dann@mothra.ics.uci.edu X-Detected-Kernel: Solaris 9 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:76036 Archived-At: David Kastrup writes: > David Kastrup writes: > > > Jason Rumney writes: > > > >> Dan Nicolaescu wrote: > >>> `vc-revert-buffer' seem to have been renamed to `vc-revert' in vc.el > >>> version 1.434 > >>> ldefs-boot.el needs to be updated... > >>> > >> > >> As a user command, I'd say it needs renaming back, or at least an alias > >> defined for it. > > > > Agreed. > > Actually, I think it needs to get renamed back. There are vc-* > subsystems maintained outside of Emacs, and those will stop working > when their hook functions get called under a different name. The vc backends maintained outside emacs already have problems with vc in CVS HEAD: a few vc functions have been changed to take a list of files as the first parameter instead of a single file. For the external vc backends: the ones for free systems have time to get in emacs until emacs-23 is released, the other ones, they'll have to be adjusted anyway... IMO the change is good, the other vc interactive commands don't have a -buffer suffix, so this makes vc more consistent. So, IMO adding an alias is the best solution here. > As an example, there is vc-git.el. It is also distributed in git's > contrib directory for the sake of users of older Emacsen and XEmacs, > and keeping it compatible would become more of a nuisance. Basically, > it would necessitate putting an alias into vc-git.el as well as > upstream vc. Alexandre Julliard, the vc-git author, said this (before vc-git was added to the 22.2 branch): "If vc-git gets merged into the Emacs 22 branch then I'll remove it from git.git, otherwise I'll probably leave it around for people who don't want to use Emacs from CVS." So I wouldn't worry about vc-git. > Unless there is a really pressing reason to keep the renamed function, > I think we should really revert here. > > -- > David Kastrup, Kriemhildstr. 15, 44793 Bochum