From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dan Nicolaescu Newsgroups: gmane.emacs.devel Subject: Re: wdired-change-to-wdired-mode needs a key binding in dired-mode Date: Fri, 27 Jul 2007 14:50:17 -0700 Message-ID: <200707272150.l6RLoHsL022174@oogie-boogie.ics.uci.edu> References: <200707240216.l6O2GiND022670@oogie-boogie.ics.uci.edu> <7dbe73ed0707232231w790d93f4o8b095a19bdc1757f@mail.gmail.com> <87bqe2493t.fsf@ambire.localdomain> <87y7h15zrk.fsf@jurta.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1185573101 7560 80.91.229.12 (27 Jul 2007 21:51:41 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Fri, 27 Jul 2007 21:51:41 +0000 (UTC) Cc: Thien-Thi Nguyen , emacs-devel@gnu.org To: Juri Linkov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Jul 27 23:51:34 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1IEXib-0002zH-J9 for ged-emacs-devel@m.gmane.org; Fri, 27 Jul 2007 23:51:29 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IEXib-0007ij-5V for ged-emacs-devel@m.gmane.org; Fri, 27 Jul 2007 17:51:29 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1IEXiR-0007cE-EH for emacs-devel@gnu.org; Fri, 27 Jul 2007 17:51:19 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1IEXiO-0007aS-L8 for emacs-devel@gnu.org; Fri, 27 Jul 2007 17:51:18 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IEXiO-0007aN-BI for emacs-devel@gnu.org; Fri, 27 Jul 2007 17:51:16 -0400 Original-Received: from oogie-boogie.ics.uci.edu ([128.195.1.41]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1IEXiN-0005Jr-Py for emacs-devel@gnu.org; Fri, 27 Jul 2007 17:51:16 -0400 Original-Received: from mothra.ics.uci.edu (mothra.ics.uci.edu [128.195.6.93]) by oogie-boogie.ics.uci.edu (8.13.6/8.13.6) with ESMTP id l6RLoHsL022174; Fri, 27 Jul 2007 14:50:17 -0700 (PDT) In-Reply-To: <87y7h15zrk.fsf@jurta.org> (Juri Linkov's message of "Fri\, 27 Jul 2007 23\:59\:27 +0300") Original-Lines: 44 X-ICS-MailScanner: Found to be clean X-ICS-MailScanner-SpamCheck: not spam, SpamAssassin (score=-0.24, required 5, autolearn=disabled, ALL_TRUSTED -1.44, J_CHICKENPOX_62 0.60, J_CHICKENPOX_65 0.60) X-ICS-MailScanner-From: dann@mothra.ics.uci.edu X-detected-kernel: Solaris 9 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:75724 Archived-At: Juri Linkov writes: > > how about `C-x C-q'? > > `C-x C-q' has one bad effect. I sometimes type `C-x C-q' in the *Locate* > buffer to remove unnecessary lines with `flush-lines' and `keep-lines' > (to narrow down usually huge result list). But now when I type `C-x C-q' > in *Locate* it raises the error: > > Debugger entered--Lisp error: (error "Not a Dired buffer") > signal(error ("Not a Dired buffer")) > error("Not a Dired buffer") > wdired-change-to-wdired-mode() > call-interactively(wdired-change-to-wdired-mode) > > Since wdired doesn't work in modes that inherit from dired-mode, > it would be useful to leave the original binding to toggle-read-only > in them: Good catch! I think vc-dired needs the same treatment, it also inherits from dired-mode. > Index: lisp/locate.el > =================================================================== > RCS file: /sources/emacs/emacs/lisp/locate.el,v > retrieving revision 1.47 > diff -c -r1.47 locate.el > *** lisp/locate.el 26 Jul 2007 05:26:28 -0000 1.47 > --- lisp/locate.el 27 Jul 2007 20:55:25 -0000 > *************** > *** 385,390 **** > --- 385,391 ---- > > (define-key locate-mode-map [M-mouse-2] 'locate-mouse-view-file) > (define-key locate-mode-map "\C-c\C-t" 'locate-tags) > + (define-key locate-mode-map "\C-x\C-q" 'toggle-read-only) > > (define-key locate-mode-map "l" 'locate-do-redisplay) > (define-key locate-mode-map "U" 'dired-unmark-all-files) > > -- > Juri Linkov > http://www.jurta.org/emacs/