wdired-change-to-wdired-mode needs a key binding in dired-mode

wdired-change-to-wdired-mode needs a key binding in dired-mode

[Dan Nicolaescu]

Right now it only has a menu entry: Immediate / Edit File Names

It would be great if it had a key binding too. 
W is still available... 

Re: wdired-change-to-wdired-mode needs a key binding in dired-mode

[Mathias Dahl]

> Right now it only has a menu entry: Immediate / Edit File Names
>
> It would be great if it had a key binding too.

I agree.

> W is still available...

Yes, W for "Wdired" or maybe E as in "Edit file names".

Re: wdired-change-to-wdired-mode needs a key binding in dired-mode

[Thien-Thi Nguyen]

how about `C-x C-q'?

thi

Re: wdired-change-to-wdired-mode needs a key binding in dired-mode

[joakim]

Thien-Thi Nguyen <ttn@gnuvola.org> writes:

> how about `C-x C-q'?
>
> thi

I use "r" for "rename" since forever. "r" is recomended in the wdired
sources. (any key would of course be fine by me)

-- 
Joakim Verona

Re: wdired-change-to-wdired-mode needs a key binding in dired-mode

[Mathias Dahl]

> how about `C-x C-q'?

That's good too as it mirrors what `toggle-read-only' does in other cases.

Re: wdired-change-to-wdired-mode needs a key binding in dired-mode

[Richard Stallman]

    how about `C-x C-q'?

That is an interesting idea.  Let's try it.

Re: wdired-change-to-wdired-mode needs a key binding in dired-mode

[Dan Nicolaescu]

Richard Stallman <rms@gnu.org> writes:

  >     how about `C-x C-q'?
  > 
  > That is an interesting idea.  Let's try it.

I added this key binding.

Re: wdired-change-to-wdired-mode needs a key binding in dired-mode

[Richard Stallman]

      >     how about `C-x C-q'?
      > 
      > That is an interesting idea.  Let's try it.

    I added this key binding.

You didn't document it.  Please add it to etc/NEWS,
then ack!

Re: wdired-change-to-wdired-mode needs a key binding in dired-mode

[Juri Linkov]

>   >     how about `C-x C-q'?
>   > 
>   > That is an interesting idea.  Let's try it.
>
> I added this key binding.

I think `C-x C-q' is a good key binding, but it has one problem.
For users who have a habit typing `C-x C-q' repeatedly to switch
between editable and read-only states, typing `C-x C-q' in wdired mode
will put the dired buffer into the confusing state: the mode line still
says "Editable Dired", but the buffer is read-only now.  Users who don't
notice %%-characters in the mode line might have a hard time finding
out what happened.

-- 
Juri Linkov
http://www.jurta.org/emacs/

Re: wdired-change-to-wdired-mode needs a key binding in dired-mode

[Stefan Monnier]

> I think `C-x C-q' is a good key binding, but it has one problem.
> For users who have a habit typing `C-x C-q' repeatedly to switch
> between editable and read-only states, typing `C-x C-q' in wdired mode
> will put the dired buffer into the confusing state: the mode line still
> says "Editable Dired", but the buffer is read-only now.  Users who don't
> notice %%-characters in the mode line might have a hard time finding
> out what happened.

Yes, there needs to be a bit more work to make the C-x C-q binding
work correctly.  That's why I didn't add the binding when I originally
installed the wdired.el code.

Now that the binding is added, let's fix the problem.


        Stefan

Re: wdired-change-to-wdired-mode needs a key binding in dired-mode

[Dan Nicolaescu]

Stefan Monnier <monnier@iro.umontreal.ca> writes:

  > > I think `C-x C-q' is a good key binding, but it has one problem.
  > > For users who have a habit typing `C-x C-q' repeatedly to switch
  > > between editable and read-only states, typing `C-x C-q' in wdired mode
  > > will put the dired buffer into the confusing state: the mode line still
  > > says "Editable Dired", but the buffer is read-only now.  Users who don't
  > > notice %%-characters in the mode line might have a hard time finding
  > > out what happened.
  > 
  > Yes, there needs to be a bit more work to make the C-x C-q binding
  > work correctly.  That's why I didn't add the binding when I originally
  > installed the wdired.el code.
  > 
  > Now that the binding is added, let's fix the problem.

Just so there's not confusion: the problem with the effects of C-x C-q
in wdired more existed before the new key bindings was added.

Now, what should C-x C-q do in wdired mode? 
How about this: 

if not buffer-modified-p
   switch back to dired-mode
else
   print a warning that the user needs to either save her changes or
   cancel them

Re: wdired-change-to-wdired-mode needs a key binding in dired-mode

[Dan Nicolaescu]

Richard Stallman <rms@gnu.org> writes:

  >       >     how about `C-x C-q'?
  >       > 
  >       > That is an interesting idea.  Let's try it.
  > 
  >     I added this key binding.
  > 
  > You didn't document it.  Please add it to etc/NEWS,
  > then ack!

I was waiting to see if the trial is successful before doing that.
Besides, I would like to add the same change to the 22.2 branch too.

But since you requested it, I added an entry to etc/NEWS and to dired.texi

Re: wdired-change-to-wdired-mode needs a key binding in dired-mode

[Juri Linkov]

>   > Now that the binding is added, let's fix the problem.
>
> Just so there's not confusion: the problem with the effects of C-x C-q
> in wdired more existed before the new key bindings was added.
>
> Now, what should C-x C-q do in wdired mode? 
> How about this: 
>
> if not buffer-modified-p
>    switch back to dired-mode
> else
>    print a warning that the user needs to either save her changes or
>    cancel them

or ask a y/n question whether save or cancel changes.

-- 
Juri Linkov
http://www.jurta.org/emacs/

Re: wdired-change-to-wdired-mode needs a key binding in dired-mode

[Richard Stallman]

    Now, what should C-x C-q do in wdired mode? 
    How about this: 

    if not buffer-modified-p
       switch back to dired-mode
    else
       print a warning that the user needs to either save her changes or
       cancel them

I prefer the later suggestion to ask whether to save or cancel them.

Re: wdired-change-to-wdired-mode needs a key binding in dired-mode

[Richard Stallman]

      > You didn't document it.  Please add it to etc/NEWS,
      > then ack!

    I was waiting to see if the trial is successful before doing that.

Please always document a change in etc/NEWS as soon as you add it.
Leaving things incomplete is not a good approach.

Re: wdired-change-to-wdired-mode needs a key binding in dired-mode

[Juri Linkov]

> how about `C-x C-q'?

`C-x C-q' has one bad effect.  I sometimes type `C-x C-q' in the *Locate*
buffer to remove unnecessary lines with `flush-lines' and `keep-lines'
(to narrow down usually huge result list).  But now when I type `C-x C-q'
in *Locate* it raises the error:

Debugger entered--Lisp error: (error "Not a Dired buffer")
  signal(error ("Not a Dired buffer"))
  error("Not a Dired buffer")
  wdired-change-to-wdired-mode()
  call-interactively(wdired-change-to-wdired-mode)

Since wdired doesn't work in modes that inherit from dired-mode,
it would be useful to leave the original binding to toggle-read-only
in them:

Index: lisp/locate.el
===================================================================
RCS file: /sources/emacs/emacs/lisp/locate.el,v
retrieving revision 1.47
diff -c -r1.47 locate.el
*** lisp/locate.el	26 Jul 2007 05:26:28 -0000	1.47
--- lisp/locate.el	27 Jul 2007 20:55:25 -0000
***************
*** 385,390 ****
--- 385,391 ----
  
     (define-key locate-mode-map [M-mouse-2] 'locate-mouse-view-file)
     (define-key locate-mode-map "\C-c\C-t"  'locate-tags)
+    (define-key locate-mode-map "\C-x\C-q"  'toggle-read-only)
  
     (define-key locate-mode-map "l"       'locate-do-redisplay)
     (define-key locate-mode-map "U"       'dired-unmark-all-files)

-- 
Juri Linkov
http://www.jurta.org/emacs/

Re: wdired-change-to-wdired-mode needs a key binding in dired-mode

[Juri Linkov]

>     Now, what should C-x C-q do in wdired mode?
>     How about this:
>
>     if not buffer-modified-p
>        switch back to dired-mode
>     else
>        print a warning that the user needs to either save her changes or
>        cancel them
>
> I prefer the later suggestion to ask whether to save or cancel them.

The following patch implements this:

Index: lisp/wdired.el
===================================================================
RCS file: /sources/emacs/emacs/lisp/wdired.el,v
retrieving revision 1.26
diff -c -r1.26 wdired.el
*** lisp/wdired.el	26 Jul 2007 05:26:37 -0000	1.26
--- lisp/wdired.el	27 Jul 2007 20:54:57 -0000
***************
*** 175,180 ****
--- 175,181 ----
      (define-key map "\C-c\C-c" 'wdired-finish-edit)
      (define-key map "\C-c\C-k" 'wdired-abort-changes)
      (define-key map "\C-c\C-[" 'wdired-abort-changes)
+     (define-key map "\C-x\C-q" 'wdired-exit)
      (define-key map "\C-m"     'ignore)
      (define-key map "\C-j"     'ignore)
      (define-key map "\C-o"     'ignore)
***************
*** 423,428 ****
--- 424,445 ----
    (set-buffer-modified-p nil)
    (setq buffer-undo-list nil))
  
+ (defun wdired-exit ()
+   "Exit wdired and return to dired mode.
+ Just return to dired mode if there are no changes.  Otherwise,
+ ask a yes-or-no question whether to save or cancel changes,
+ and proceed depending on the answer."
+   (interactive)
+   (if (buffer-modified-p)
+       (if (y-or-n-p (format "Buffer %s modified; save changes? "
+ 			    (current-buffer)))
+ 	  (wdired-finish-edit)
+ 	(wdired-abort-changes))
+     (wdired-change-to-dired-mode)
+     (set-buffer-modified-p nil)
+     (setq buffer-undo-list nil)
+     (message "(No changes need to be saved)")))
+ 
  ;; Rename a file, searching it in a modified dired buffer, in order
  ;; to be able to use `dired-do-create-files-regexp' and get its
  ;; "benefits".

-- 
Juri Linkov
http://www.jurta.org/emacs/

Re: wdired-change-to-wdired-mode needs a key binding in dired-mode

[Dan Nicolaescu]

Juri Linkov <juri@jurta.org> writes:

  > > how about `C-x C-q'?
  > 
  > `C-x C-q' has one bad effect.  I sometimes type `C-x C-q' in the *Locate*
  > buffer to remove unnecessary lines with `flush-lines' and `keep-lines'
  > (to narrow down usually huge result list).  But now when I type `C-x C-q'
  > in *Locate* it raises the error:
  > 
  > Debugger entered--Lisp error: (error "Not a Dired buffer")
  >   signal(error ("Not a Dired buffer"))
  >   error("Not a Dired buffer")
  >   wdired-change-to-wdired-mode()
  >   call-interactively(wdired-change-to-wdired-mode)
  > 
  > Since wdired doesn't work in modes that inherit from dired-mode,
  > it would be useful to leave the original binding to toggle-read-only
  > in them:

Good catch! I think vc-dired needs the same treatment, it also
inherits from dired-mode.


  > Index: lisp/locate.el
  > ===================================================================
  > RCS file: /sources/emacs/emacs/lisp/locate.el,v
  > retrieving revision 1.47
  > diff -c -r1.47 locate.el
  > *** lisp/locate.el	26 Jul 2007 05:26:28 -0000	1.47
  > --- lisp/locate.el	27 Jul 2007 20:55:25 -0000
  > ***************
  > *** 385,390 ****
  > --- 385,391 ----
  >   
  >      (define-key locate-mode-map [M-mouse-2] 'locate-mouse-view-file)
  >      (define-key locate-mode-map "\C-c\C-t"  'locate-tags)
  > +    (define-key locate-mode-map "\C-x\C-q"  'toggle-read-only)
  >   
  >      (define-key locate-mode-map "l"       'locate-do-redisplay)
  >      (define-key locate-mode-map "U"       'dired-unmark-all-files)
  > 
  > -- 
  > Juri Linkov
  > http://www.jurta.org/emacs/

Re: wdired-change-to-wdired-mode needs a key binding in dired-mode

[Leo]

On 2007-07-27 22:50 +0100, Dan Nicolaescu wrote:
> Good catch! I think vc-dired needs the same treatment, it also
> inherits from dired-mode.

Why not just bind wdired-change-to-wdired-mode to 'r'? It is easier and
avoid all the confusion.

-- 
Leo <sdl.web AT gmail.com>                         (GPG Key: 9283AA3F)

Re: wdired-change-to-wdired-mode needs a key binding in dired-mode

[Stefan Monnier]

> Since wdired doesn't work in modes that inherit from dired-mode,
> it would be useful to leave the original binding to toggle-read-only
> in them:

Rather than "fix" each derived mode one by one, how 'bout doing

  (define-key dired-mode-map "\C-x\C-q"
    '(menu-item nil wdired-change-to-wdired-mode
      :filter (lambda (x) (if (eq major-mode 'dired-mode) x))))

Or maybe more simply create a new function dired-toggle-read-only which
either calls wdired-change-to-wdired-mode or toggle-read-only depending on
whether wdired makes sense or not (by testing (eq major-mode 'dired-mode) or
whatever else).


        Stefan

Re: wdired-change-to-wdired-mode needs a key binding in dired-mode

[Juri Linkov]

>> Since wdired doesn't work in modes that inherit from dired-mode,
>> it would be useful to leave the original binding to toggle-read-only
>> in them:
>
> Rather than "fix" each derived mode one by one, how 'bout doing
>
>   (define-key dired-mode-map "\C-x\C-q"
>     '(menu-item nil wdired-change-to-wdired-mode
>       :filter (lambda (x) (if (eq major-mode 'dired-mode) x))))
>
> Or maybe more simply create a new function dired-toggle-read-only which
> either calls wdired-change-to-wdired-mode or toggle-read-only depending on
> whether wdired makes sense or not (by testing (eq major-mode 'dired-mode) or
> whatever else).

I prefer a new function.  That's what I already thought about after seeing
that Dan mentioned vc-dired.

-- 
Juri Linkov
http://www.jurta.org/emacs/

Re: wdired-change-to-wdired-mode needs a key binding in dired-mode

[Richard Stallman]

Please install it.

Re: wdired-change-to-wdired-mode needs a key binding in dired-mode

[Richard Stallman]

    `C-x C-q' has one bad effect.  I sometimes type `C-x C-q' in the *Locate*
    buffer to remove unnecessary lines with `flush-lines' and `keep-lines'
    (to narrow down usually huge result list).  But now when I type `C-x C-q'
    in *Locate* it raises the error:

Please install your change.

Re: wdired-change-to-wdired-mode needs a key binding in dired-mode

[Juri Linkov]

> Please install it.

Done.

-- 
Juri Linkov
http://www.jurta.org/emacs/

Re: wdired-change-to-wdired-mode needs a key binding in dired-mode

[Juri Linkov]

>     `C-x C-q' has one bad effect.  I sometimes type `C-x C-q' in the *Locate*
>     buffer to remove unnecessary lines with `flush-lines' and `keep-lines'
>     (to narrow down usually huge result list).  But now when I type `C-x C-q'
>     in *Locate* it raises the error:
>
> Please install your change.

I installed it with a new function dired-toggle-read-only agreed with Stefan.

-- 
Juri Linkov
http://www.jurta.org/emacs/

Re: wdired-change-to-wdired-mode needs a key binding in dired-mode

[Dan Nicolaescu]

Juri Linkov <juri@jurta.org> writes:

  > > Please install it.
  > 
  > Done.

How about putting all these wdired/dired changes on the 22.2 branch? 

Re: wdired-change-to-wdired-mode needs a key binding in dired-mode

[Richard Stallman]

    How about putting all these wdired/dired changes on the 22.2 branch? 

No, I would rather not risk it.  I don't want to add features in
Emacs 22 unless they are totally modular.