From: Dan Nicolaescu <dann@ics.uci.edu>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel@gnu.org
Subject: Re: undo info for `*cvs-diff*'
Date: Wed, 25 Jul 2007 09:53:29 -0700 [thread overview]
Message-ID: <200707251653.l6PGrTJ5011302@oogie-boogie.ics.uci.edu> (raw)
In-Reply-To: <jwvy7h5hyxm.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Wed\, 25 Jul 2007 00\:48\:50 -0400")
Stefan Monnier <monnier@iro.umontreal.ca> writes:
> > ,----[ *Warnings* ]
> > | Warning (undo): Buffer `*cvs-diff*' undo info was 5641808 bytes long.
> > | The undo info was discarded because it exceeded `undo-outer-limit'.
> > | [...]
> > `----
>
> I believe I know what was causing this trouble. Can you try the
> patch below which I just installed in the 22 branch?
>
>
> Stefan
>
>
> --- pcvs.el 25 jui 2007 00:41:22 -0400 1.98.2.4
> +++ pcvs.el 25 jui 2007 00:43:49 -0400
> @@ -392,17 +392,18 @@
> (with-current-buffer buf
> (setq buffer-read-only nil)
> (setq default-directory dir)
> - (unless nosetup (erase-buffer))
> + (unless nosetup
> + (buffer-disable-undo)
> + (erase-buffer))
> (set (make-local-variable 'cvs-buffer) cvs-buf)
> ;;(cvs-minor-mode 1)
> (let ((lbd list-buffers-directory))
> - (if (fboundp mode) (funcall mode)
> - (fundamental-mode)
> - (buffer-disable-undo))
> + (if (fboundp mode) (funcall mode) (fundamental-mode))
> (when lbd (set (make-local-variable 'list-buffers-directory) lbd)))
> (cvs-minor-mode 1)
> ;;(set (make-local-variable 'cvs-buffer) cvs-buf)
> - (unless normal
> + (if normal
> + (buffer-enable-undo)
> (setq buffer-read-only t)
> (buffer-disable-undo))
> buf)))
Applying it to HEAD makes the problem disappear for me.
Thanks!
next prev parent reply other threads:[~2007-07-25 16:53 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-23 21:22 undo info for *cvs-tmp* Dan Nicolaescu
2007-07-24 1:09 ` Stefan Monnier
2007-07-24 18:29 ` Reiner Steib
2007-07-24 19:34 ` Stefan Monnier
2007-07-24 21:28 ` undo info for `*cvs-diff*' (was: undo info for *cvs-tmp*) Reiner Steib
2007-07-25 4:48 ` undo info for `*cvs-diff*' Stefan Monnier
2007-07-25 16:53 ` Dan Nicolaescu [this message]
2007-07-24 19:33 ` undo info for *cvs-tmp* Stefan Monnier
2007-07-24 20:40 ` Dan Nicolaescu
2007-07-24 22:03 ` Stefan Monnier
2007-07-24 22:16 ` Dan Nicolaescu
2007-07-25 15:02 ` Richard Stallman
2007-07-24 16:45 ` Richard Stallman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200707251653.l6PGrTJ5011302@oogie-boogie.ics.uci.edu \
--to=dann@ics.uci.edu \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.