From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Timo Savola Newsgroups: gmane.emacs.devel Subject: Re: XEmbed patches Date: Fri, 20 Jul 2007 11:24:25 +0300 Message-ID: <20070720082425.GD27107@movial.fi> References: <20070718142537.GA27107@movial.fi> <46A05BFA.2010900@swipnet.se> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable X-Trace: sea.gmane.org 1184919882 3949 80.91.229.12 (20 Jul 2007 08:24:42 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Fri, 20 Jul 2007 08:24:42 +0000 (UTC) Cc: rms@gnu.org, emacs-devel@gnu.org To: Jan =?iso-8859-1?Q?Dj=E4rv?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Jul 20 10:24:39 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1IBnmw-0004PZ-Eg for ged-emacs-devel@m.gmane.org; Fri, 20 Jul 2007 10:24:38 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IBnmv-0005bd-Ja for ged-emacs-devel@m.gmane.org; Fri, 20 Jul 2007 04:24:37 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1IBnms-0005bO-C5 for emacs-devel@gnu.org; Fri, 20 Jul 2007 04:24:34 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1IBnmr-0005bC-LT for emacs-devel@gnu.org; Fri, 20 Jul 2007 04:24:34 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IBnmr-0005b9-Ib for emacs-devel@gnu.org; Fri, 20 Jul 2007 04:24:33 -0400 Original-Received: from smtp.movial.fi ([62.236.91.34]) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1IBnmo-0007LG-8m; Fri, 20 Jul 2007 04:24:30 -0400 Original-Received: from localhost (mailscanner.hel.movial.fi [172.17.81.9]) by smtp.movial.fi (Postfix) with ESMTP id 3C6E3C808D; Fri, 20 Jul 2007 08:24:26 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at movial.fi Original-Received: from smtp.movial.fi ([62.236.91.34]) by localhost (mailscanner.hel.movial.fi [172.17.81.9]) (amavisd-new, port 10026) with ESMTP id kf+HJl26Zb7E; Fri, 20 Jul 2007 08:24:26 +0000 (UTC) Original-Received: from ext-ssh.movial.fi (ext-ssh.movial.fi [62.236.91.4]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.movial.fi (Postfix) with ESMTP id 246ABC8085; Fri, 20 Jul 2007 08:24:26 +0000 (UTC) Original-Received: by ext-ssh.movial.fi (Postfix, from userid 1033) id 0BE792006C; Fri, 20 Jul 2007 11:24:26 +0300 (EEST) Content-Disposition: inline In-Reply-To: <46A05BFA.2010900@swipnet.se> User-Agent: Mutt/1.5.9i X-detected-kernel: Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:75157 Archived-At: On Fri, Jul 20, 2007 at 08:53:46AM +0200, Jan Dj=E4rv wrote: > Oh, I forgot. I think the Gtk+ scrollbar patch looks bad if you have a= =20 > theme where the scroll bar isn't as wide as the character width. The=20 > current behaviour puts the excess on both sides. With your patch, the=20 > excess are on one side only. The point of that patch is to make the embedded Emacs blend into the surrounding (assumedly) GTK application. Without it, it leaves a gap between the GTK-themed background color of the scrollbar and the GTK-them= ed embedder window. Making the gap wider on the Emacs side seems like a smaller bad. (Aligning the scrollbar seamlessly against the X window border might also look better with some window manager themes designed for GTK-based desktops.) My patch changes that unconditionally--not just for embedded frames. Als= o, the assumption that the embedder is always a GTK application doesn't hold water. I do see this as an issue, however, but I don't know the correct solution= . Here are my proposed solutions: 1. Enable it on embedded frames. 2. Make it configurable so that the embedder which launches Emacs can choose it. (This seems like a huge hammer for such a small nail as we're talking about a non-functional issue which exists with only one= of the supported GUI toolkits.) 3. All of the above. > But if we can get rid of the requirement that=20 > scroll bar width must equal a character width, this would not be an iss= ue. Is this a realistic expectation? timo