From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dan Nicolaescu Newsgroups: gmane.emacs.devel Subject: Re: add a tooltip and a mouse binding to the VC mode-line entry Date: Mon, 09 Jul 2007 10:48:14 -0700 Message-ID: <200707091748.l69HmTC8026198@oogie-boogie.ics.uci.edu> References: <200707031711.l63HB39F025974@oogie-boogie.ics.uci.edu> <200707051545.l65FjSgW019871@oogie-boogie.ics.uci.edu> <20070706.140607.81800388.jet@gyve.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1184003379 16093 80.91.229.12 (9 Jul 2007 17:49:39 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Mon, 9 Jul 2007 17:49:39 +0000 (UTC) Cc: Masatake YAMATO , emacs-devel@gnu.org To: rms@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Jul 09 19:49:37 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1I7xMf-0002mj-2z for ged-emacs-devel@m.gmane.org; Mon, 09 Jul 2007 19:49:37 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1I7xMe-0000N1-ME for ged-emacs-devel@m.gmane.org; Mon, 09 Jul 2007 13:49:36 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1I7xMb-0000M7-Jk for emacs-devel@gnu.org; Mon, 09 Jul 2007 13:49:33 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1I7xMa-0000Lv-Ti for emacs-devel@gnu.org; Mon, 09 Jul 2007 13:49:33 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1I7xMa-0000Lm-NU for emacs-devel@gnu.org; Mon, 09 Jul 2007 13:49:32 -0400 Original-Received: from oogie-boogie.ics.uci.edu ([128.195.1.41]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1I7xMZ-0003DY-JD; Mon, 09 Jul 2007 13:49:31 -0400 Original-Received: from gamera.ics.uci.edu (gamera.ics.uci.edu [128.195.6.224]) by oogie-boogie.ics.uci.edu (8.13.6/8.13.6) with ESMTP id l69HmTC8026198; Mon, 9 Jul 2007 10:48:29 -0700 (PDT) In-Reply-To: <20070706.140607.81800388.jet@gyve.org> (Masatake YAMATO's message of "Fri\, 06 Jul 2007 14\:06\:07 +0900 \(JST\)") Original-Lines: 32 X-ICS-MailScanner: Found to be clean X-ICS-MailScanner-SpamCheck: not spam, SpamAssassin (score=-1.44, required 5, autolearn=disabled, ALL_TRUSTED -1.44) X-ICS-MailScanner-From: dann@gamera.ics.uci.edu X-detected-kernel: Solaris 9 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:74513 Archived-At: Masatake YAMATO writes: > > Here's a little patch that adds a tooltip to the VC entry on the > > mode line and it also makes mouse-1 on that entry to pop up the VC > > operations menu. > > > > It would be good if people would try it and say if it useful based on > > _actual usage experience_, not just speculation. After that we can > > change the text for the tooltip, add more mouse bindings or even > > decide not to install the whole thing. > > Looks good. Now I can hide the menu bar:-P. > > @@ -291,7 +303,10 @@ > 'mode-line-buffer-identification > (propertize " " 'help-echo help-echo) > 'mode-line-position > - '(vc-mode vc-mode) > + (list > + `(:propertize ("" vc-mode) help-echo "Version Control mouse-1: VC menu" > + mouse-face mode-line-highlight > + local-map ,mode-line-vc-mode-keymap)) > (propertize " " 'help-echo help-echo) > 'mode-line-modes > `(which-func-mode ("" which-func-format ,dashes)) > > I think this should be done in `vc-mode-line'. > Look at `vc-default-mode-line-string'. > Telling the meaning of `:' or `-' in the tooltip string may help users. Can you please OK a change along these lines? All the comments on adding this feature were positive.