From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Eric M. Ludlam" Newsgroups: gmane.emacs.devel Subject: Re[2]: Strange behaviour after Show/Hide Speedbar in Emacs 22.1 Date: Mon, 25 Jun 2007 09:17:07 -0400 Message-ID: <200706251317.l5PDH7J1011619@projectile.siege-engine.com> References: NNTP-Posting-Host: lo.gmane.org X-Trace: sea.gmane.org 1182777439 14026 80.91.229.12 (25 Jun 2007 13:17:19 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Mon, 25 Jun 2007 13:17:19 +0000 (UTC) Cc: Angelo.Graziosi@roma1.infn.it, emacs-devel@gnu.org To: "Juanma Barranquero" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Jun 25 15:17:17 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1I2oRP-0008Iq-Es for ged-emacs-devel@m.gmane.org; Mon, 25 Jun 2007 15:17:15 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1I2oRO-0007Cy-My for ged-emacs-devel@m.gmane.org; Mon, 25 Jun 2007 09:17:14 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1I2oRL-0007Br-Ch for emacs-devel@gnu.org; Mon, 25 Jun 2007 09:17:11 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1I2oRJ-0007Bf-Bc for emacs-devel@gnu.org; Mon, 25 Jun 2007 09:17:10 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1I2oRJ-0007Bc-6U for emacs-devel@gnu.org; Mon, 25 Jun 2007 09:17:09 -0400 Original-Received: from static-71-184-83-10.bstnma.fios.verizon.net ([71.184.83.10] helo=projectile.siege-engine.com) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1I2oRI-0000ZB-Ta for emacs-devel@gnu.org; Mon, 25 Jun 2007 09:17:09 -0400 Original-Received: from projectile.siege-engine.com (localhost.localdomain [127.0.0.1]) by projectile.siege-engine.com (8.12.8/8.12.8) with ESMTP id l5PDH7YE011623; Mon, 25 Jun 2007 09:17:07 -0400 Original-Received: (from zappo@localhost) by projectile.siege-engine.com (8.12.8/8.12.8/Submit) id l5PDH7J1011619; Mon, 25 Jun 2007 09:17:07 -0400 In-reply-to: (lekktu@gmail.com) X-detected-kernel: Linux 2.4-2.6 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:73808 Archived-At: Hi, The speedbar frame stays "live" but hidden so that the next time speedbar comes up, it will be faster. You can use 'q' to hide speedbar, and 'Q' to really kill speedbar. I tried it out, and it seems the speed difference is currently very small now, so the optimization is not as important as it once was. I suspect your patch might leave a bunch of invisible frames about, but it's been a while since I've been in that code so I'm not sure. Eric >>> "Juanma Barranquero" seems to think that: >On 6/25/07, Angelo Graziosi wrote: > >> It look as if the speedbar were still 'live' > >It is live, if somewhat hidden :) > >Try the following patch. > > Juanma > > >P.S.: Eric, is this patch OK? > > > >Index: lisp/speedbar.el >=================================================================== >RCS file: /cvsroot/emacs/emacs/lisp/speedbar.el,v >retrieving revision 1.87 >diff -u -2 -r1.87 speedbar.el >--- lisp/speedbar.el 19 Feb 2007 13:37:23 -0000 1.87 >+++ lisp/speedbar.el 25 Jun 2007 10:24:07 -0000 >@@ -1012,6 +1012,8 @@ > ) > ;; Frame modifications >- (set (make-local-variable 'dframe-delete-frame-function) >- 'speedbar-handle-delete-frame) >+ (if speedbar-frame >+ (set (make-local-variable 'dframe-delete-frame-function) >+ 'speedbar-handle-delete-frame) >+ (kill-local-variable 'dframe-delete-frame-function)) > ;; hscroll > (set (make-local-variable 'automatic-hscrolling) nil) ; Emacs 21 > -- Eric Ludlam: zappo@gnu.org, eric@siege-engine.com Home: http://www.ludlam.net Siege: www.siege-engine.com Emacs: http://cedet.sourceforge.net GNU: www.gnu.org