From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dan Nicolaescu Newsgroups: gmane.emacs.devel Subject: Re: vera-mode.el Date: Sun, 10 Jun 2007 09:08:21 -0700 Message-ID: <200706101608.l5AG8MLL007414@oogie-boogie.ics.uci.edu> References: <4665C2DC.3090102@synopsys.com> <4666EB5D.7040909@gnu.org> <46672780.30202@synopsys.com> <200706062338.l56NcSrt009870@oogie-boogie.ics.uci.edu> <4667F51D.5060707@synopsys.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1181491846 29637 80.91.229.12 (10 Jun 2007 16:10:46 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sun, 10 Jun 2007 16:10:46 +0000 (UTC) Cc: Stefan Monnier , emacs-devel@gnu.org To: Reto Zimmermann Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Jun 10 18:10:43 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1HxQ02-00083v-HC for ged-emacs-devel@m.gmane.org; Sun, 10 Jun 2007 18:10:42 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HxQ02-0003oq-1p for ged-emacs-devel@m.gmane.org; Sun, 10 Jun 2007 12:10:42 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1HxPzq-0003iO-0R for emacs-devel@gnu.org; Sun, 10 Jun 2007 12:10:30 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1HxPzp-0003hk-7t for emacs-devel@gnu.org; Sun, 10 Jun 2007 12:10:29 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HxPzo-0003hC-QP for emacs-devel@gnu.org; Sun, 10 Jun 2007 12:10:28 -0400 Original-Received: from oogie-boogie.ics.uci.edu ([128.195.1.41]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1HxPzo-00073l-DN for emacs-devel@gnu.org; Sun, 10 Jun 2007 12:10:28 -0400 Original-Received: from mothra.ics.uci.edu (mothra.ics.uci.edu [128.195.6.93]) by oogie-boogie.ics.uci.edu (8.13.6/8.13.6) with ESMTP id l5AG8MLL007414; Sun, 10 Jun 2007 09:08:22 -0700 (PDT) In-Reply-To: <4667F51D.5060707@synopsys.com> (Reto Zimmermann's message of "Thu\, 07 Jun 2007 14\:07\:57 +0200") Original-Lines: 43 X-ICS-MailScanner: Found to be clean X-ICS-MailScanner-SpamCheck: not spam, SpamAssassin (score=-1.44, required 5, autolearn=disabled, ALL_TRUSTED -1.44) X-ICS-MailScanner-From: dann@mothra.ics.uci.edu X-detected-kernel: Solaris 9 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:72583 Archived-At: Reto Zimmermann writes: > Dan Nicolaescu wrote: > > > Thanks for submitting this code! > > > > Reto Zimmermann writes: > > > > > > > (defface vera-font-lock-number-face > > > > Faces don't have "-face" suffix anymore now, some face names have been > > kept for compatibility, but it would be good not to introduce new > > ones. For this you'd need to do something like: (defface vera-font-lock-number-face ... ...) (put 'vera-font-lock-number 'face-alias 'vera-font-lock-number-face) > > > > > (defface vera-font-lock-function-face > > > > Any reason you are not using font-lock-function-name-face here? > > > > font-lock is on by default in emacs-22, so there's a set of 15 > > predefined faces that you could use. > > > > Can you use the predefined font-lock faces for any of the faces that > > vera-mode uses? > > I added these faces because I wanted even more colors do distinguish > different language elements and I didn't find appropriate colors in > the predefined faces. I am already using font-lock-function-name-face > for something else. So I would like to keep these additional colors > because it was a user wish. Note that my code was not an objection in any way, just making sure that there's a good reason for adding these faces, and there is. What is the next step? IMHO this code is ready to be checked in.